Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "share_target" property #665

Open
tomayac opened this issue Apr 16, 2018 · 10 comments
Open

Add support for "share_target" property #665

tomayac opened this issue Apr 16, 2018 · 10 comments
Labels

Comments

@tomayac
Copy link
Contributor

tomayac commented Apr 16, 2018

Since according to @PaulKinlan's post Chrome started supporting the Web Share Target API (implementing the Draft Community Group Report 27 February 2018), and since no other than Twitter added the proposed syntax in their manifest, it might be a great point in time to consider adding the "share_target" property to the Web App Manifest spec. Here is the relevant extract of Twitter's manifest, showcasing the proposed syntax with the three URL placeholders {title}, {text}, and {url}:

"share_target": {
    "url_template": "compose/tweet?title={title}&text={text}&url={url}"
}

I reckon this is a bit of a 🐔 and 🥚 problem, as they both depend on each other. Happy to help with either.

@kenchris
Copy link
Collaborator

I believe Matt originally wrote this as an extension spec to Web App Manifest - but I wouldn't mind having it in the web app manifest spec itself

@kenchris
Copy link
Collaborator

@tomayac
Copy link
Contributor Author

tomayac commented Apr 16, 2018

Yepp, it feels more "at home" in the Web App Manifest spec.

@kenchris
Copy link
Collaborator

I really hope we can get people from Microsoft involved with this @boyofgreen @patrickkettner @kirupa

@tomayac
Copy link
Contributor Author

tomayac commented Apr 16, 2018

I'd say $MSFT are pretty invested here 👏: https://www.windowsobserver.com/2018/04/11/twitter-pwa-on-windows-10-now-a-share-target/

@kenchris
Copy link
Collaborator

TAG review yielded some new suggestions: w3ctag/design-reviews#221 (comment)

@kenchris
Copy link
Collaborator

Some comments from MS @boyofgreen https://twitter.com/boyofgreen/status/986075414685626368?s=20

we find a number of scenerios where launch events make a lot of sense. We can tell you how you were luanched (from a tile or from a toast or from another app), payload, etc. it would be messy to put that all in the URI

@mgiuca
Copy link
Collaborator

mgiuca commented May 24, 2018

I only just saw this. (Lots of people have been @-mentioned in this thread but not me #sad).

This was always intended to be incorporated into the manifest spec once complete, but it isn't finalized yet. I didn't want to work in a branch off the manifest spec so I created a separate repo.

it might be a great point in time to consider adding the "share_target" property to the Web App Manifest spec

Note that the TAG review is ongoing and major changes to the syntax are being proposed. The API is not available in Chrome Stable (only on Dev and Canary channel on Android). We are not ready to land this in any spec that is being implemented by real browsers. Please keep discussion of this on the WICG issue tracker for web-share-target: https://github.com/WICG/web-share-target/issues

@tomayac
Copy link
Contributor Author

tomayac commented May 24, 2018

SGTM, closing the issue for now.

@tomayac tomayac closed this as completed May 24, 2018
@mgiuca
Copy link
Collaborator

mgiuca commented May 28, 2018

I think it's helpful to keep this open as a top-level tracking issue for the Manifest standard to incorporate WST once that goes ahead. Re-opening for now, but still, discuss details on the WST issue tracker.

@mgiuca mgiuca reopened this May 28, 2018
@mgiuca mgiuca added the Defer Until after REC label May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants