-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix coordinate system enum #56
Conversation
That comment says
This is just adding a namespace (not that common in other specs) and it becomes as long as the worst Java APIs :-( Can't we move it to the Generic Sensor spec instead and keep the name? |
Why no response on my comment? :-) |
@kenchris, the local coordinate system concept applies only to spatial sensors, and not all sensors that extend the Generic Sensor API. Enums are not web-exposed, so verbose enum names do not cause any ergonomics issues as in Java APIs. |
Well, they will be exposed in TypeScript project for intellisense :-) These will most likely be generated from Web IDL (Microsoft has work ongoing on making that happen), which means you will also spread these over your code (You add type declarations when using TS) - so yes, this might actually pose a real problem. Though they only apply to some sensors, I don't see why they cannot be in the generic spec. They might be useful for future specs down the road. You can just add a Spatial Sensors section and maybe make it optional to implement unless you implement some of the derivative specs |
Call it `OrientationSensorLocalCoordinateSystem` per w3c/orientation-sensor#56.
…eSystem enum., a=testonly Automatic update from web-platform-testsorientation-sensor: Rename LocalCoordinateSystem enum. (#9975) Call it `OrientationSensorLocalCoordinateSystem` per w3c/orientation-sensor#56. wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa wpt-pr: 9975 wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa wpt-pr: 9975
…eSystem enum., a=testonly Automatic update from web-platform-testsorientation-sensor: Rename LocalCoordinateSystem enum. (#9975) Call it `OrientationSensorLocalCoordinateSystem` per w3c/orientation-sensor#56. wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa wpt-pr: 9975 wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa wpt-pr: 9975 UltraBlame original commit: 545c0ad0a16ed7458f4fdd11be6a0b435044417d
…eSystem enum., a=testonly Automatic update from web-platform-testsorientation-sensor: Rename LocalCoordinateSystem enum. (#9975) Call it `OrientationSensorLocalCoordinateSystem` per w3c/orientation-sensor#56. wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa wpt-pr: 9975 wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa wpt-pr: 9975 UltraBlame original commit: 545c0ad0a16ed7458f4fdd11be6a0b435044417d
…eSystem enum., a=testonly Automatic update from web-platform-testsorientation-sensor: Rename LocalCoordinateSystem enum. (#9975) Call it `OrientationSensorLocalCoordinateSystem` per w3c/orientation-sensor#56. wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa wpt-pr: 9975 wpt-commits: 71b44f991df620aa9c06497b4049e720d1bce3aa wpt-pr: 9975 UltraBlame original commit: 545c0ad0a16ed7458f4fdd11be6a0b435044417d
Fix w3c/accelerometer#41 (comment)
Preview | Diff