New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebIDL Section 3.2.2: "sequence" as an attribute prohibited #43

Closed
aboba opened this Issue Apr 2, 2014 · 1 comment

Comments

Projects
None yet
2 participants
@aboba
Copy link
Contributor

aboba commented Apr 2, 2014

From Shijun Sun:

The WebIDL specification Section 3.2.2 third paragraph states that “sequence” as attribute is explicitly prohibited:
(see http://www.w3.org/TR/WebIDL/#idl-attributes):

"The type of the attribute MUST NOT be a sequence type or nullable sequence type, and it MUST NOT be a union type if one of its member types (or one of its member types’s member types, and so on) is a sequence type or nullable sequence type."

There are a few places in the current spec, RTCIceTransport and RTCIceListener, where we should consider changing the attributes to methods, for example, getXXXX() that returns a sequence or object.

@aboba

This comment has been minimized.

Copy link
Contributor

aboba commented Apr 10, 2014

From Shijun:

Here is the text from WebIDL (http://www.w3.org/TR/WebIDL/) Section 3.2.2:

"The type of the attribute MUST NOT be a sequence type or nullable sequence type, and it MUST NOT be a union type if one of its member types (or one of its member types’s member types, and so on) is a sequence type or nullable sequence type."

Proposed fix:

partial interface RTCIceTransport {
sequence getLocalCandidates ();
sequence getRemoteCandidates ();
}

partial interface RTCIceListener {
sequence getLocalCandidates ();
}

robin-raymond pushed a commit to robin-raymond/ortc that referenced this issue Apr 12, 2014

Robin Raymond
Support for contributing source information added, as described in w3…
…c#27

Support for control of quality, resolution, framerate and layering added, as described inhttps://github.com/w3c/issues/31
RTCRtpListener object added and figure in Section 1 updated, as described in w3c#32
More complete support for RTP and Codec Parameters added, as described in w3c#33
Data Channel transport problem fixed, as described in w3c#34
Various NITs fixed, as described in w3c#37
Section 2.2 and 2.3 issues fixed, as described in w3c#38
Default values of some dictionary attributes added, to partially address the issue described in w3c#39
Support for ICE TCP added, as described in w3c#41
Fixed issue with sequences as attributes, as described in w3c#43
Fix for issues with onlocalcandidate, as described in w3c#44
Initial stab at a Stats API, as requested in w3c#46
Added support for ICE gather policy, as described in w3c#47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment