Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCRtpEncodingParameters minQuality defaulted (and others) #505

Closed
robin-raymond opened this issue Apr 25, 2016 · 3 comments
Closed

RTCRtpEncodingParameters minQuality defaulted (and others) #505

robin-raymond opened this issue Apr 25, 2016 · 3 comments

Comments

@robin-raymond
Copy link
Contributor

dictionary RTCRtpEncodingParameters {
             unsigned long       ssrc;
             payloadtype         codecPayloadType;
             RTCRtpFecParameters fec;
             RTCRtpRtxParameters rtx;
             RTCPriorityType     priority;
             unsigned long       maxBitrate;
             double              minQuality = 0;
             double              resolutionScale;
             double              framerateScale;
             unsigned long       maxFramerate;
             boolean             active = true;
             DOMString           encodingId;
             sequence<DOMString> dependencyEncodingIds;
};

I'm uncertain why minQuality is defaulted rather than left unset. I think there's need to review all the defaults and make sure they are all accurate.

@aboba
Copy link
Contributor

aboba commented Apr 25, 2016

To me, it does not make much sense to allow the quality of a stream to deteriorate to the lowest possible level by default. IMHO it would make more sense to drop the stream before that happens.

related Issue: #351

@aboba aboba added the 1.1 label Apr 25, 2016
@aboba
Copy link
Contributor

aboba commented Apr 25, 2016

Since we don't know what minQuality does, why not remove it?

@robin-raymond
Copy link
Contributor Author

robin-raymond commented Apr 25, 2016

@aboba kill this minQuality thing; no clear guidance on what an implementer is supposed to do with it; until someone comes up with use case and guidance I don't think it should exist either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants