Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global variables #35

Closed
annevk opened this issue May 6, 2015 · 3 comments
Closed

Remove global variables #35

annevk opened this issue May 6, 2015 · 3 comments

Comments

@annevk
Copy link
Member

annevk commented May 6, 2015

A bunch of algorithms invoke each other without passing along the variables clearly. It's unlikely this English would pass a compiler.

@annevk
Copy link
Member Author

annevk commented May 6, 2015

As an example, query() invokes "create" in step 4 and passes it two variables yet "create" only accepts one. Since the first argument "create" accepts is a permission and it is passed a global object this would likely crash if I were to attempt to implement this.

@mounirlamouri
Copy link
Member

I fixed the invocation of create: 485a7ce

Please, reopen or file another bug if you see another instance where the passed arguments are wrong.

@annevk
Copy link
Member Author

annevk commented Jun 16, 2015

Please make it easier to file issues then by including something like file-issue.js as other specifications do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants