Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify GC model #360

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Simplify GC model #360

merged 1 commit into from
Feb 9, 2022

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Feb 9, 2022

closes #266

The following tasks have been completed:

Implementation commitment:


Preview | Diff

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Feb 9, 2022

Added test: web-platform-tests/wpt#30189

Checking manually with the code below, this doesn't appear to be implemented in WebKit or Gecko (but works fine in Chrome).

(async () => {
  const perm = await navigator.permissions.query({ name: "geolocation" });
  perm.onchange = console.log;
  console.log("going out of scope")
  // bye bye perm
})();
// prompts for permission
navigator.geolocation.getCurrentPosition(console.log);

@marcoscaceres
Copy link
Member Author

Filed bugs for Gecko and WebKit...

@miketaylr miketaylr changed the title Simplify CG model Simplify GC model Feb 9, 2022
@marcoscaceres
Copy link
Member Author

I’ll see if I can patch Gecko.

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miketaylr miketaylr merged commit a15aaa7 into main Feb 9, 2022
@miketaylr miketaylr deleted the gc branch February 9, 2022 21:23
github-actions bot added a commit that referenced this pull request Feb 9, 2022
SHA: a15aaa7
Reason: push, by @miketaylr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition of PermissionStatus lifetime
2 participants