Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoPictureInPicture HTMLVideoElement attribute #216

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented Dec 5, 2022

This PR is about removing the autoPictureInPicture HTMLVideoElement attribute from the spec. The only browser that implemented it for experimental purposes was Chrome and it never shipped.

@steimelchrome PTAL


Preview | Diff

@steimelchrome
Copy link

Changes lgtm but looks like the build was unsuccessful

index.bs Outdated Show resolved Hide resolved
@beaufortfrancois
Copy link
Collaborator Author

FYI @chrisn @jernoble

@beaufortfrancois beaufortfrancois merged commit f51cdfa into main Dec 6, 2022
@beaufortfrancois beaufortfrancois deleted the remove-autopip branch December 6, 2022 08:30
github-actions bot added a commit that referenced this pull request Dec 6, 2022
SHA: f51cdfa
Reason: push, by beaufortfrancois

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 6, 2022
This CL removes the autoPictureInPicture HTMLVideoElement attribute as
it was only used for experimental purposes in Chrome and it never
shipped. It has been removed from the spec as well.

Spec: w3c/picture-in-picture#216
Bug: 917303
Change-Id: Ie9cd9136a2c8632a86cf85eff4aec50843514685
@chrisn
Copy link
Member

chrisn commented Dec 6, 2022

caniuse says autoPictureInPictureElement is implemented in Safari, so want to confirm with @jernoble.

@beaufortfrancois
Copy link
Collaborator Author

autoPictureInPicture is in WebKit but doesn't actually do anything. See https://github.com/search?q=repo%3AWebKit%2FWebKit+autoPictureInPicture&type=code

Same applies to disablePictureInPicture: https://github.com/search?q=repo%3AWebKit%2FWebKit+disablePictureInPicture&type=code

@chrisn
Copy link
Member

chrisn commented Dec 6, 2022

Thanks!

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 8, 2022
This CL removes the autoPictureInPicture HTMLVideoElement attribute as
it was only used for experimental purposes in Chrome and it never
shipped. It has been removed from the spec as well.

Spec: w3c/picture-in-picture#216
Bug: 917303
Change-Id: Ie9cd9136a2c8632a86cf85eff4aec50843514685
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 8, 2022
This CL removes the autoPictureInPicture HTMLVideoElement attribute as
it was only used for experimental purposes in Chrome and it never
shipped. It has been removed from the spec as well.

Spec: w3c/picture-in-picture#216
Bug: 917303
Change-Id: Ie9cd9136a2c8632a86cf85eff4aec50843514685
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 8, 2022
This CL removes the autoPictureInPicture HTMLVideoElement attribute as
it was only used for experimental purposes in Chrome and it never
shipped. It has been removed from the spec as well.

Spec: w3c/picture-in-picture#216
Bug: 917303
Change-Id: Ie9cd9136a2c8632a86cf85eff4aec50843514685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4079109
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1080837}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 8, 2022
This CL removes the autoPictureInPicture HTMLVideoElement attribute as
it was only used for experimental purposes in Chrome and it never
shipped. It has been removed from the spec as well.

Spec: w3c/picture-in-picture#216
Bug: 917303
Change-Id: Ie9cd9136a2c8632a86cf85eff4aec50843514685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4079109
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1080837}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Dec 8, 2022
This CL removes the autoPictureInPicture HTMLVideoElement attribute as
it was only used for experimental purposes in Chrome and it never
shipped. It has been removed from the spec as well.

Spec: w3c/picture-in-picture#216
Bug: 917303
Change-Id: Ie9cd9136a2c8632a86cf85eff4aec50843514685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4079109
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1080837}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Dec 12, 2022
…ment attribute, a=testonly

Automatic update from web-platform-tests
Remove autoPictureInPicture HTMLVideoElement attribute

This CL removes the autoPictureInPicture HTMLVideoElement attribute as
it was only used for experimental purposes in Chrome and it never
shipped. It has been removed from the spec as well.

Spec: w3c/picture-in-picture#216
Bug: 917303
Change-Id: Ie9cd9136a2c8632a86cf85eff4aec50843514685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4079109
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1080837}

--

wpt-commits: df2b9160a0c1b0d30561f0f7701ba1e2e02131bd
wpt-pr: 37347
BruceDai pushed a commit to BruceDai/wpt that referenced this pull request Dec 13, 2022
This CL removes the autoPictureInPicture HTMLVideoElement attribute as
it was only used for experimental purposes in Chrome and it never
shipped. It has been removed from the spec as well.

Spec: w3c/picture-in-picture#216
Bug: 917303
Change-Id: Ie9cd9136a2c8632a86cf85eff4aec50843514685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4079109
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1080837}
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Dec 14, 2022
…ment attribute, a=testonly

Automatic update from web-platform-tests
Remove autoPictureInPicture HTMLVideoElement attribute

This CL removes the autoPictureInPicture HTMLVideoElement attribute as
it was only used for experimental purposes in Chrome and it never
shipped. It has been removed from the spec as well.

Spec: w3c/picture-in-picture#216
Bug: 917303
Change-Id: Ie9cd9136a2c8632a86cf85eff4aec50843514685
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4079109
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1080837}

--

wpt-commits: df2b9160a0c1b0d30561f0f7701ba1e2e02131bd
wpt-pr: 37347
sideshowbarker added a commit to mdn/browser-compat-data that referenced this pull request Apr 18, 2023
w3c/picture-in-picture#216 removed
HTMLVideoElement»autoPictureInPicture from the spec, and while the
current BCD data indicates it was implemented in Safari, that’s not
strictly true.

w3c/picture-in-picture#216 (comment)
explains:
> autoPictureInPicture is in WebKit but doesn't actually do anything.
> See https://github.com/search?q=repo%3AWebKit%2FWebKit+autoPictureInPicture&type=code

So it won’t ever actually do anything in Safari, and won’t ever be
implemented in other browsers; so we should remove it from BCD rather
than just it hanging around — because it’s not something that web
developers will ever be able to actually use, anywhere.
sideshowbarker added a commit to mdn/browser-compat-data that referenced this pull request Apr 18, 2023
w3c/picture-in-picture#216 removed
HTMLVideoElement»autoPictureInPicture from the spec, and while the
current BCD data indicates it was implemented in Safari, that’s not
strictly true.

w3c/picture-in-picture#216 (comment)
explains:
> autoPictureInPicture is in WebKit but doesn't actually do anything.
> See https://github.com/search?q=repo%3AWebKit%2FWebKit+autoPictureInPicture&type=code

So it won’t ever actually do anything in Safari, and won’t ever be
implemented in other browsers; so we should remove it from BCD rather
than just it hanging around — because it’s not something that web
developers will ever be able to actually use, anywhere.
sideshowbarker added a commit to mdn/browser-compat-data that referenced this pull request Apr 18, 2023
w3c/picture-in-picture#216 removed
HTMLVideoElement»autoPictureInPicture from the spec, and while the
current BCD data indicates it was implemented in Safari, that’s not
strictly true.

w3c/picture-in-picture#216 (comment)
explains:
> autoPictureInPicture is in WebKit but doesn't actually do anything.
> See https://github.com/search?q=repo%3AWebKit%2FWebKit+autoPictureInPicture&type=code

So it won’t ever actually do anything in Safari, and won’t ever be
implemented in other browsers; so we should remove it from BCD rather
than just it hanging around — because it’s not something that web
developers will ever be able to actually use, anywhere.
sideshowbarker added a commit to mdn/browser-compat-data that referenced this pull request Apr 18, 2023
w3c/picture-in-picture#216 removed
HTMLVideoElement»autoPictureInPicture from the spec, and while the
current BCD data indicates it was implemented in Safari, that’s not
strictly true.

w3c/picture-in-picture#216 (comment)
explains:
> autoPictureInPicture is in WebKit but doesn't actually do anything.
> See https://github.com/search?q=repo%3AWebKit%2FWebKit+autoPictureInPicture&type=code

So it won’t ever actually do anything in Safari, and won’t ever be
implemented in other browsers; so we should remove it from BCD rather
than just it hanging around — because it’s not something that web
developers will ever be able to actually use, anywhere.
sideshowbarker added a commit to mdn/browser-compat-data that referenced this pull request Apr 18, 2023
w3c/picture-in-picture#216 removed
HTMLVideoElement»autoPictureInPicture from the spec, and while the
current BCD data indicates it was implemented in Safari, that’s not
strictly true.

w3c/picture-in-picture#216 (comment)
explains:
> autoPictureInPicture is in WebKit but doesn't actually do anything.
> See https://github.com/search?q=repo%3AWebKit%2FWebKit+autoPictureInPicture&type=code

So it won’t ever actually do anything in Safari, and won’t ever be
implemented in other browsers; so we should remove it from BCD rather
than just it hanging around — because it’s not something that web
developers will ever be able to actually use, anywhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants