-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TFO and secureConnectionStart #120
Comments
Seems to me that the behavior you suggest (
BTW, a similar question applies to |
The core L2 concern is whether ordering MUST be: Current assumptions are that failures do not reset start times. TFO without secureConnectionStart COULD have the following order: Should requestStart reset when an error occurs? @nicjansma, can you follow up on ordering in various browsers? Should we enforce ordering in the spec? |
Assuming ordering is clear, lets add ensuring times are reset on retry errors to all entries. |
FWIW, Safari's implementation would return the connection start time of the successful connection, not the very first attempt. |
Gathering some data on how often we see "non-standard" ordering in the wild. |
Our team looked at some of the aggregate data we collect, and we found the following:
For the later 3 cases, we're not entirely sure if it's a mixture of browser bugs, new technologies like QUIC changing the presumed ordering of things, or even bugs in how we're collecting / compressing the data. Broken down by popular user agents, the percentage of entries a browser was showing a "nonstandard ordering" (any of the above cases):
@toddreifsteck it's interesting that Edge is showing a larger percentage of non-standard orderings than IE 9-11. My takeaway: We will probably need to be flexible in the future with some orderings, but others seem like they should always MUST be in a certain order (e.g. As an analytics vendor, expecting to see timestamps in a specific order helps a lot with validating, compressing and visualizing the data. So it is nice to have some expected order. But we probably need to allow for some flexibility for cases like QUIC/TFO and future awesome. |
Followups from the 2017-12-14 call:
|
I suspect testing this will not be feasible, as there's no way I'm aware of to force a browser to use TFO. |
My reading of the processing model's steps 14, 15 and 16 is that they do not relate to each other, and therefore order such as what you suggest here is indeed allowed. |
@igrigorik @yoavweiss
When TFO is enabled in clients https://datatracker.ietf.org/doc/rfc7413/ , should we expect connectionStart and secureConnectionStart to have identical times?
Does that specification need to clarify this?
This could be confusing for folks that are using secureConnectionStart from telemetry.
The text was updated successfully, but these errors were encountered: