-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection reuse does not imply DNS was not required #185
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -524,11 +524,12 @@ <h3>The <dfn>PerformanceResourceTiming</dfn> Interface</h3> | |
<p data-dfn-for="PerformanceResourceTiming">On getting, the | ||
<dfn>domainLookupStart</dfn> attribute MUST return as follows:</p> | ||
<ol data-link-for="PerformanceResourceTiming"> | ||
<li>The same value as <a>fetchStart</a>, if a <a href= | ||
<li>The same value as <a>fetchStart</a>, if no domain lookup was | ||
required to fetch the resources (e.g. due to the fact that a <a href= | ||
"https://tools.ietf.org/html/RFC7230#section-6.3">persistent | ||
connection</a> [[RFC7230]] is used or the resource is retrieved | ||
from <a data-cite="HTML#relevant-application-cache">relevant | ||
application caches</a> or local resources.</li> | ||
connection</a> [[RFC7230]] was used or in case the resource was | ||
retrieved from <a data-cite="HTML#relevant-application-cache">relevant | ||
application caches</a> or local resources).</li> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we also need this change the other places we mention "persistent connection"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not all of them, but I did leave out domainLookupEnd... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added. PTAL? |
||
<li>The time immediately after the user agent before the domain | ||
data retrieval from the domain information cache, if the user agent | ||
has the domain information in cache.</li> | ||
|
@@ -1063,7 +1064,7 @@ <h3>Processing Model</h3> | |
"https://tools.ietf.org/html/rfc7234">HTTP cache</a> [[RFC7234]], | ||
go to step <a href="#dfn-step-request-start">14</a>.</li> | ||
<li>If no domain lookup is required, go to step <a href= | ||
"#dfn-step-connect-start">12</a>. Otherwise, immediately before a | ||
"#dfn-step-connect-start">14</a>. Otherwise, immediately before a | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Drive-by fix |
||
user agent starts the domain name lookup, record the time as | ||
<a>domainLookupStart</a>.</li> | ||
<li>Record the time as <a>domainLookupEnd</a> immediately after the | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/due to the fact that/if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack