Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce network requests on core/biblio #2461

Closed
saschanaz opened this issue Aug 1, 2019 · 1 comment · Fixed by #2462
Closed

Reduce network requests on core/biblio #2461

saschanaz opened this issue Aug 1, 2019 · 1 comment · Fixed by #2462

Comments

@saschanaz
Copy link
Member

respec/src/core/biblio.js

Lines 150 to 156 in 103f318

if (externalRefs.length) {
// Going to the network for refs we don't have
const data = await updateFromNetwork(externalRefs, { forceUpdate: true });
Object.assign(biblio, data);
}
Object.assign(biblio, conf.localBiblio);
await updateFromNetwork(neededRefs);

Those two serial requests are one of the major performance bottlenecks in #2187. Maybe we can merge them into one request, or at least we should make them parallel.

@saschanaz
Copy link
Member Author

saschanaz commented Aug 1, 2019

@marcoscaceres Any idea why we request twice here? (It's introduced by #1018.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant