Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core/biblio): remove redundant request #2462

Merged
merged 1 commit into from Aug 1, 2019
Merged

refactor(core/biblio): remove redundant request #2462

merged 1 commit into from Aug 1, 2019

Conversation

saschanaz
Copy link
Member

@saschanaz saschanaz commented Aug 1, 2019 •
edited

Removing that line shouldn't make any change, as both split.hasData and split.noData are already processed.

Closes #2461

marcoscaceres
marcoscaceres approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, whoops 😬 nice find.

@saschanaz saschanaz merged commit fea0ae5 into develop Aug 1, 2019
@saschanaz saschanaz deleted the single-request branch August 1, 2019 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce network requests on core/biblio
2 participants
@saschanaz @marcoscaceres