🎄 Goodies

[marcoscaceres]

🎄 New features:

• 🎁 ReSpec now keeps a local copy of references and aliases in IDB. This means dramatically improved load times.
• 🎁 Support for <a data-cite=spec#some-ref>, so you can inline cite
• 🎁 Support for <a data-cite-frag=some-ref>, which is the same above.

[marcoscaceres]

Ok, so Firefox 50 (the one served by travis is buggy, it seems). I can't reproduce locally (all tests pass) - but it passes in Chrome just fine, and same in Safari.

[marcoscaceres]

@halindrome, let me know how you want to handle review of this. I know it's a lot of code.

[halindrome]

I will try to dig into it soon. I've been on other work related stuff lately!

…

On Jan 6, 2017 1:07 PM, "Marcos Cáceres" ***@***.***> wrote: @halindrome <https://github.com/halindrome>, let me know how you want to handle review of this. I know it's a lot of code. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1018 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAfx8OVl6oFhYemuu_N3VRwI6UiFea4vks5rPpEJgaJpZM4Lb1Zu> .

[marcoscaceres]

I'm going to merge this in, as I need data-cite for the Web Payment Spec. Would still really appreciate a post merge review.

[halindrome]

This change is too large and complex for me to review effectively. Moreover, I personally don't understand async / await. Didn't even know it existed. I am very uncomfortable with our continued introduction of bleeding edge features into a tool that is expected to be used by people who do not have bleeding edge user agents. I assume respec now has some polyfill that supports async / await on older user agents. If it does not, well, that's going to be a problem.

[halindrome]

Newline missing?

[marcoscaceres]

Fyi, it's all transpiled to es5 so it works in older browsers :) it only gives the illusion of bleeding edge.

…

On 9 Jan 2017, at 11:00 pm, Shane McCarron ***@***.***> wrote: @halindrome commented on this pull request. This change is too large and complex for me to review effectively. Moreover, I personally don't understand async / await. Didn't even know it existed. I am very uncomfortable with our continued introduction of bleeding edge features into a tool that is expected to be used by people who do not have bleeding edge user agents. I assume respec now has some polyfill that supports async / await on older user agents. If it does not, well, that's going to be a problem. In tests/spec/core/data-cite-spec.js: > + data-cite="!WHATWG-HTML#fail" + data-cite-frag="pass">inline link</a></p> + </section> + `, + }; + makeRSDoc(ops).then(doc => { + const a = doc.querySelector("#t1 > a"); + expect(a.textContent).toEqual("inline link"); + expect(a.href).toEqual("https://html.spec.whatwg.org/multipage/#pass"); + expect(a.hasAttribute("data-cite")).toEqual(false); + expect(doc.querySelector("#bib-WHATWG-HTML").closest("section").id) + .toEqual("normative-references"); + }).then(done); + }); + }); +}); Newline missing? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[marcoscaceres]

Sorry also about the size. This was a big one as it added a pretty important new feature (and it was basically my xmas break - I need to get a life;)). Anyway, I'll send an email to spec-prod explaining the new features. Some smaller bug fixes incoming.

…

On 10 Jan 2017, at 1:25 am, ***@***.*** wrote: Fyi, it's all transpiled to es5 so it works in older browsers :) it only gives the illusion of bleeding edge. > On 9 Jan 2017, at 11:00 pm, Shane McCarron ***@***.***> wrote: > > @halindrome commented on this pull request. > > This change is too large and complex for me to review effectively. Moreover, I personally don't understand async / await. Didn't even know it existed. I am very uncomfortable with our continued introduction of bleeding edge features into a tool that is expected to be used by people who do not have bleeding edge user agents. I assume respec now has some polyfill that supports async / await on older user agents. If it does not, well, that's going to be a problem. > > In tests/spec/core/data-cite-spec.js: > > > + data-cite="!WHATWG-HTML#fail" > + data-cite-frag="pass">inline link</a></p> > + </section> > + `, > + }; > + makeRSDoc(ops).then(doc => { > + const a = doc.querySelector("#t1 > a"); > + expect(a.textContent).toEqual("inline link"); > + expect(a.href).toEqual("https://html.spec.whatwg.org/multipage/#pass"); > + expect(a.hasAttribute("data-cite")).toEqual(false); > + expect(doc.querySelector("#bib-WHATWG-HTML").closest("section").id) > + .toEqual("normative-references"); > + }).then(done); > + }); > + }); > +}); > Newline missing? > > — > You are receiving this because you modified the open/close state. > Reply to this email directly, view it on GitHub, or mute the thread. >