Improve patent text on notes #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcoscaceres
commented
Dec 14, 2017
marcoscaceres
commented
- closes Upcoming update to WG notes patent policy text #1443
|
@deniak, let me know if this looks right. |
deniak
requested changes
Dec 15, 2017
There was a problem hiding this comment.
@marcoscaceres Except for the name of the status, that PR looks good.
src/w3c/headers.js
Outdated
| @@ -634,11 +634,23 @@ export function run(conf, doc, cb) { | |||
| conf.isPR = conf.specStatus === "PR"; | |||
| conf.isPER = conf.specStatus === "PER"; | |||
| conf.isMO = conf.specStatus === "MO"; | |||
| conf.isNote = conf.specStatus === "NOTE"; | |||
There was a problem hiding this comment.
Looking at the documentation, shouldn't the status be WG-NOTE?
There was a problem hiding this comment.
You are correct, there is also FPWD-NOTE, it seems. I still don't know why we have "NOTE"? It seems to be "a thing" - it has an associated W3C Style? Should we kill that?
tests/spec/w3c/headers-spec.js
Outdated
| it("gracefully handles missing wgPatentURI", async () => { | ||
| const ops = makeStandardOps(); | ||
| const newProps = { | ||
| specStatus: "NOTE", |
tests/spec/w3c/headers-spec.js
Outdated
| const ops = makeStandardOps(); | ||
| const newProps = { | ||
| wgPatentURI: "https://www.w3.org/pp-impl/123456/status", | ||
| specStatus: "NOTE", |
marcoscaceres
force-pushed
the
patent_note
branch
from
533187f
to
ac2face
Compare
marcoscaceres
commented
Dec 18, 2017
| @@ -634,11 +634,23 @@ export function run(conf, doc, cb) { | |||
| conf.isPR = conf.specStatus === "PR"; | |||
| conf.isPER = conf.specStatus === "PER"; | |||
| conf.isMO = conf.specStatus === "MO"; | |||
| conf.isNote = ["FPWD-NOTE", "WG-NOTE"].includes(conf.specStatus); | |||
There was a problem hiding this comment.
@deniak, let me know if "FPWD-NOTE" applies or not. I'm was unsure.
deniak
approved these changes
Dec 18, 2017
|
Will release later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.