Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ping SpecRef in ordering-safe way #1499

Merged
merged 5 commits into from Feb 12, 2018
Merged

fix: ping SpecRef in ordering-safe way #1499

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba7a73d
fix: ping in ordering-safe way
saschanaz Feb 12, 2018
6959e04
variable ordering is still important
saschanaz Feb 12, 2018
4b31c94
specRefOk
saschanaz Feb 12, 2018
75bf710
use specrefok
saschanaz Feb 12, 2018
f1e731e
no need to access .ok
saschanaz Feb 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/spec/core/biblio-spec.js
View file
Open in desktop
Expand Up @@ -59,18 +59,17 @@ describe("W3C — Bibliographic References", () => {
`;

afterAll(flushIframes);
let isSpecRefAvailable = false;
const bibRefsURL = new URL("https://specref.herokuapp.com/bibrefs");
const specRefPing = fetch(bibRefsURL, { method: "HEAD" });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's move this to beforeAll, and await it there...

  specRefOk = (await specRefPing).ok;


let doc;
beforeAll(async () => {
doc = await makeRSDoc({ config, body });
});

it("pings biblio service to see if it's running", async () => {
const res = await fetch(bibRefsURL, { method: "HEAD" });
const res = await specRefPing;
expect(res.ok).toBeTruthy();
isSpecRefAvailable = res.ok;
});

it("includes a dns-prefetch to bibref server", () => {
Expand All @@ -85,7 +84,7 @@ describe("W3C — Bibliographic References", () => {
let ref = doc.querySelector("#bib-TestRef1 + dd");
expect(ref).toBeTruthy();
// This prevents Jasmine from taking down the whole test suite if SpecRef is down.
if (!isSpecRefAvailable) {
if (!(await specRefPing).ok) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops... here needs updating too.

throw new Error(
"SpecRef seems to be down. Can't proceed with this spec."
);
Expand Down