fix: ping SpecRef in ordering-safe way #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/spec/core/biblio-spec.js
Outdated
| const bibRefsURL = new URL("https://specref.herokuapp.com/bibrefs"); | ||
| const specRefPing = fetch(bibRefsURL, { method: "HEAD" }); |
There was a problem hiding this comment.
let's move this to beforeAll, and await it there...
specRefOk = (await specRefPing).ok;
marcoscaceres
approved these changes
Feb 12, 2018
tests/spec/core/biblio-spec.js
Outdated
| @@ -85,7 +85,7 @@ describe("W3C — Bibliographic References", () => { | |||
| let ref = doc.querySelector("#bib-TestRef1 + dd"); | |||
| expect(ref).toBeTruthy(); | |||
| // This prevents Jasmine from taking down the whole test suite if SpecRef is down. | |||
| if (!isSpecRefAvailable) { | |||
| if (!(await specRefPing).ok) { | |||
There was a problem hiding this comment.
Ooops... here needs updating too.
tests/spec/core/biblio-spec.js
Outdated
| @@ -85,7 +84,7 @@ describe("W3C — Bibliographic References", () => { | |||
| let ref = doc.querySelector("#bib-TestRef1 + dd"); | |||
| expect(ref).toBeTruthy(); | |||
| // This prevents Jasmine from taking down the whole test suite if SpecRef is down. | |||
| if (!(await specRefPing).ok) { | |||
| if (!specRefOk.ok) { | |||
There was a problem hiding this comment.
Sorry, this should just be if(!specRefOk){ ... } as specRefOk is just a boolean and won't have a .ok member, right?
marcoscaceres
approved these changes
Feb 12, 2018
|
Sorry for intermediate messes 🤣 |
|
So, I guess this one closes #828 |
marcoscaceres
added a commit
that referenced
this pull request
Feb 12, 2018
* develop: v19.2.0 docs(examples): use github config option (#1500) fix(tools/release): use build:components instead (#1501) fix: ping SpecRef in ordering-safe way (#1499) chore: update dependencies (#1498) fix: prevent unordered tests from conflicting (#1495) refactor: remove WebIDL array support (#1496) Feat: link to pull requests in headers Skip detectBrowsers when explicitly passing browsers (#1490) refactor: use node.js api rather than unix commands (#1488) refactor: use puppeteer instead of nightmare (#1483) chore(package): update jasmine-core to version 3.0.0 (#1481) workaround: use sudo required on travis (#1478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.