refactor: use await for makeRSDoc() #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
force-pushed
the
await-makersrdoc
branch
from
c571de9
to
4ec7e56
Compare
marcoscaceres
approved these changes
Jul 28, 2018
| null, | ||
| "display: block" | ||
| ); | ||
| resolve(); |
There was a problem hiding this comment.
Is this still testing that clicking makes the pill go away?
There was a problem hiding this comment.
I think so, as it tests display after clicking repeatedly.
marcoscaceres
added a commit
that referenced
this pull request
Jul 31, 2018
* develop: v22.3.3 refactor(core/jquery-enhanced): migrate $linkTargets to vanilla js (#1785) refactor: remove `var` (#1784) fix(core/idl): linking attribute id/type with same name (#1776) refactor(tests/spec/core/webidl-spec): remove remaining jQuery (#1783) refactor: lint tests (#1782) refactor: use const and arrow functions (#1781) refactor: use getElementById whenever possible (#1780) refactor: use await for makeRSDoc() (#1779) fix(karma.conf.js): grep causes incorrect skips (#1778) Force eslint (#1777) refactor(tests/spec/core/webidl-spec): remove jQuery from dict/enum tests (#1775) refactor(tests/spec/core/webidl-spec): remove jQuery from op/comment tests (#1774) refactor(tests/spec/core/webidl-spec): remove jQuery from ctor/const/attr tests (#1773) refactor(tests/spec/core/webidl-spec): remove jQuery from interface tests (#1772)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and remove deprecated callbacks.