Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for additional links in header (closes #87) #208

Merged
merged 15 commits into from May 3, 2013
Merged

Support for additional links in header (closes #87) #208

merged 15 commits into from May 3, 2013

Conversation

marcoscaceres
Copy link
Member

馃拑 Adds support for custom header links. 馃拑

馃専 Supports automagic hyperlink creation and multiple dd's values for each key.

Example of what it looks like:

Screen Shot 2013-04-28 at 22 44 02

New property "otherLinks", and example:

otherLinks: [{
      key: "Repo",
      value: "We are on Github",
      href: "https://github.com/darobin/respec"
  }, {
      key: "Bug tracker",
      href: "https://github.com/darobin/respec/issues?state=open"
  }, {
      key: "No linking",
      value: "I don't hyperlink."
  }, {
      key: "Previous Editors",
      data: [{
              value: "John Smith",
              href: "http://example.com"
          }, {
              value: "Adam Smith"
          }, {
              value: "Foobar Smith"
          }
      ]
  }
]

Note: I'm not 100% happy with the names of the properties I used, but if you guys are ok with them, I can live with them.

@marcoscaceres
Copy link
Member Author

Just remembered that I had filed this one 7 months ago: https://github.com/darobin/respec/issues/87

@tobie
Copy link
Member

tobie commented Apr 29, 2013

Can't merge this. Think you could rebase?

@marcoscaceres
Copy link
Member Author

oki, should be good now... for some reason, "git up" didn't fetch the remove changes on the develop branch?

@ghost ghost assigned darobin Apr 30, 2013
@tobie
Copy link
Member

tobie commented Apr 30, 2013

Deferring to @darobin for approval as this is a new feature and I'm polite.

@marcoscaceres
Copy link
Member Author

On Tuesday, April 30, 2013, Tobie Langel wrote:

Deferring to @darobin https://github.com/darobin for approval as this
is a new feature and I'm polite.

Thanks @tobie, np. If you have any comments or suggestions/improvements
(specially about the prop names), I would appreciate them.

Marcos Caceres
http://datadriven.com.au

@marcoscaceres
Copy link
Member Author

@darobin ping

darobin added a commit that referenced this pull request May 3, 2013
Support for additional links in header (closes #87)
@darobin darobin merged commit 3086573 into w3c:develop May 3, 2013
@darobin
Copy link
Member

darobin commented May 3, 2013

LGTM, thanks a lot. This will ship in the next release.

Just one small comment: the CG document headers use a different template (there were just too many differences to factor them into a single template) and so won't benefit from this change. You could register this as a partial, and make it available in both.

@darobin
Copy link
Member

darobin commented May 3, 2013

Also, pinging me in GitHub comments works best when I'm not on vacation ;)

@marcoscaceres marcoscaceres deleted the additional_header_links branch May 3, 2013 13:08
@marcoscaceres
Copy link
Member Author

And I thought people went on vacation to spend moar time on the github! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants