Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/notoc #421

Merged
merged 2 commits into from Apr 2, 2015
Merged

Feature/notoc #421

merged 2 commits into from Apr 2, 2015

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Apr 2, 2015

This adds support for the class "notoc" on a section to cause the section to be omitted from the TOC.
Fixes #419.

darobin added a commit that referenced this pull request Apr 2, 2015
@darobin darobin merged commit 85ea816 into w3c:develop Apr 2, 2015
@halindrome
Copy link
Contributor

I don't mind this, nor that it was merged. However, for a11y purposes it may be the case that headers that are NOT in the ToC are also headers that should not be 'landmarks' from an ARIA perspective. I will raise this with the PFWG since they are our experts on the topic. @michael-n-cooper can you please put this on the agenda?

@michael-n-cooper
Copy link
Member

My personal opinion is these sections should still be landmarks even if
it the author prefers not to include them in the TOC. But that's just a
personal opinion. I have put this on the agenda for the next PF editors
meeting. Michael

On 02/04/2015 9:30 AM, Shane McCarron wrote:

I don't mind this, nor that it was merged. However, for a11y purposes
it may be the case that headers that are NOT in the ToC are also
headers that should not be 'landmarks' from an ARIA perspective. I
will raise this with the PFWG since they are our experts on the topic.
@michael-n-cooper https://github.com/michael-n-cooper can you please
put this on the agenda?


Reply to this email directly or view it on GitHub
#421 (comment).

@halindrome
Copy link
Contributor

Thanks. On a related note, we probably shouldn't be using headers for the
role / state /property definitions in aria core since these are not really
sections... Also for the editors to hash out.
On Apr 6, 2015 10:46 AM, "michael-n-cooper" notifications@github.com
wrote:

My personal opinion is these sections should still be landmarks even if
it the author prefers not to include them in the TOC. But that's just a
personal opinion. I have put this on the agenda for the next PF editors
meeting. Michael

On 02/04/2015 9:30 AM, Shane McCarron wrote:

I don't mind this, nor that it was merged. However, for a11y purposes
it may be the case that headers that are NOT in the ToC are also
headers that should not be 'landmarks' from an ARIA perspective. I
will raise this with the PFWG since they are our experts on the topic.
@michael-n-cooper https://github.com/michael-n-cooper can you please
put this on the agenda?


Reply to this email directly or view it on GitHub
#421 (comment).


Reply to this email directly or view it on GitHub
#421 (comment).

@michael-n-cooper
Copy link
Member

PF editors discussed this and said don´t exclude sections from being landmarks just because they have been exluded from TOC. I think that means no change from current behaviour. Tangent issues are on future PF editors agenda but probably don't need to be tracked in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix-headers incorrectly messes with non-section headers
4 participants