Put note text back the way it was.

[halindrome]

To fix issue #653. This puts everything back the way it was. 'cause notes dont pass pubrules now.

[marcoscaceres]

Can I kindly ask that PRs not be merged without review. We shouldn't hot fix stuff as it just introduces more cruft. It is possible for users to self-fix the generated versions, while we figure out appropriate solutions to bugs.

[halindrome]

You are of course correct. In my defense, I should never have agreed to the original change in the first place. In fact, when I went and looked at the PR there were other things in there I wouldn't have agreed to had I actually been paying attention when I looked at it. That's my fault.

[marcoscaceres]

On 16 Mar 2016, at 7:08 PM, Shane McCarron notifications@github.com wrote:

You are of course correct. In my defense, I should never have agreed to the original change in the first place. In fact, when I went and looked at the PR there were other things in there I wouldn't have agreed to had I actually been paying attention when I looked at it. That's my fault.

I wouldn't say it's your fault, but the process is there for a reason (and I strongly believe it works): Marcos, or any of the maintainers, will on occasion propose less than ideal PRs. Each PR requires as much consideration from the reviewer as the code the PR adds/removes. Having said that, we will on occasion make mistakes. And that's totally ok. We have the luxury here that, in an organization where it takes on average 5 years to get to REC, a delay of a day or two fixing a bug or merging a PR is not a big deal.

So, it's totally ok to say, "I don't like this... I need to sleep on it... Have you maybe thought of doing it this way... Etc."

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub