Fix whitespace issues #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .shift(1); | ||
| return leftPad || 0; | ||
| } | ||
| return (match.length < smallest) ? match.length : smallest; |
|
LGTM with a possible minor improvement; not sure why the Travis CI PR build failed (but the branch push seems to be happy) |
|
Travis fails intermittently even though everything passes 😢 . Running the tests again fixes it. |
marcoscaceres
force-pushed
the
fix_whitespace
branch
from
476ba18
to
d7c68c3
Compare
|
@dontcallmedom thanks for review! |
shikhar-scs
pushed a commit
to shikhar-scs/respec
that referenced
this pull request
Feb 19, 2018
update link from d3 3.5.0 to v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is