Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to replace DOMStringMap? #412

Closed
dirkschulze opened this issue Apr 12, 2018 · 4 comments
Closed

Do we need to replace DOMStringMap? #412

dirkschulze opened this issue Apr 12, 2018 · 4 comments

Comments

@dirkschulze
Copy link
Contributor

When updating links from HTML5.1 CR to HTML 5.2 I couldn't find an interface for DOMStringMap in the newer spec. Do we have to replace our use of it on the dataset attribute for SVGElement? Or did it move to a different page of the HTML5 spec and I just oversaw it?

@dstorey
Copy link
Member

dstorey commented Apr 12, 2018

It is defined here: https://html.spec.whatwg.org/multipage/dom.html#domstringmap

I think this is ok as it is though as HTML has already moved out dataset into a shared mixin for HTML and SVG to use: https://html.spec.whatwg.org/multipage/dom.html#htmlorsvgelement

We just need to update to include that mixin. I'm unblocked on doing that now the new syntax has been merged.

@dirkschulze
Copy link
Contributor Author

@dstorey So far we reference HTML5 exclusively I think. Would be the first WHATWG reference in the SVG spec.

@dstorey
Copy link
Member

dstorey commented Apr 12, 2018

I believe we decided on the call to update to use WhatWG for now as there are things in WHATWG that we need that are not in W3C HTML. And if that became a problem at CR then we could look into it again. There are already some references to WhatWG (Fetch, links in linking.html for #AElementRelAttribute et al.)

@AmeliaBR
Copy link
Contributor

For what it's worth, W3C HTML has DOMStringMap defined: ED, 5.2

But yes, we've already decided to switch to WHATWG so we can use the HTMLOrSVGElement mixin to harmonize these types of things, so that will take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants