This repository has been archived by the owner on Sep 19, 2018. It is now read-only.
Don't error out trying to access cross-origin functions when document.domain got set. #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….domain got set. Setting document.domain changes the origin of the current document to be different to the origin it had before. This invalidates the cache of origins, so in this case we need to catch the error and make sure we don't try to call a cross-origin function.
|
Critic review: https://critic.hoppipolla.co.uk/r/4619 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Ms2ger
added a commit
that referenced
this pull request
Apr 10, 2015
Don't error out trying to access cross-origin functions when document.domain got set; r=Ms2ger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting document.domain changes the origin of the current document to be different
to the origin it had before. This invalidates the cache of origins, so in this case
we need to catch the error and make sure we don't try to call a cross-origin function.