Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "status" to "message" for statusPurpose feature. #100

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Rename "status" to "message" for statusPurpose feature. #100

merged 2 commits into from
Jan 13, 2024

Conversation

msporny
Copy link
Member

@msporny msporny commented Dec 27, 2023 •
edited by pr-preview bot

This PR renames the awkwardly named "status" "statusPurpose" field to "message" since the "statusPurpose" is about conveying arbitrary messages to verifiers. This PR will close out issue #42 if merged.

Preview | Diff

dlongley
dlongley approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestion on better unifying the results from the "validate algorithm".

index.html Outdated Show resolved Hide resolved
TallTed
TallTed approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @dlongley's adjustment, and mine to his.

@msporny @dlongley
Clean up Validate algorithm to be easier to read.
94fb1cc 
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
@iherman
Copy link
Member

iherman commented Jan 10, 2024

The issue was discussed in a meeting on 2024-01-10

  • no resolutions were taken
View the transcript

3.1. Rename "status" to "message" for statusPurpose feature. (pr vc-bitstring-status-list#100)

See github pull request vc-bitstring-status-list#100.

Manu Sporny: we had 3 status purpose values: revocation, suspension and status.
… we have changed status to message.
… we have pre-pended the word status to some of the property names.

See github pull request vc-bitstring-status-list#105.

@iherman iherman mentioned this pull request Jan 10, 2024
Merged
@msporny
Copy link
Member Author

msporny commented Jan 13, 2024

Normative, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 1001292 into main Jan 13, 2024
1 of 2 checks passed
@msporny msporny deleted the msporny-rename-status branch January 13, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@TallTed TallTed TallTed approved these changes

@David-Chadwick David-Chadwick David-Chadwick approved these changes

@brianorwhatever brianorwhatever brianorwhatever approved these changes

@decentralgabe decentralgabe decentralgabe approved these changes

@brentzundel brentzundel brentzundel approved these changes

@KDean-GS1 KDean-GS1 KDean-GS1 approved these changes

@jandrieu jandrieu Awaiting requested review from jandrieu

@longpd longpd Awaiting requested review from longpd

@iherman iherman Awaiting requested review from iherman

@dmitrizagidulin dmitrizagidulin Awaiting requested review from dmitrizagidulin

@selfissued selfissued Awaiting requested review from selfissued

@seabass-labrax seabass-labrax Awaiting requested review from seabass-labrax

@mprorock mprorock Awaiting requested review from mprorock mprorock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@msporny @iherman @dlongley @TallTed @David-Chadwick @brianorwhatever @decentralgabe @brentzundel @KDean-GS1