Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on Section 6.2 Terms of Use #234

Closed
riannella opened this issue Sep 15, 2018 · 6 comments
Closed

Comments on Section 6.2 Terms of Use #234

riannella opened this issue Sep 15, 2018 · 6 comments
Assignees
Labels
HorizontalReview ready for PR This issue is ready for a Pull Request to be created to resolve it review-blocker

Comments

@riannella
Copy link

The ODRL Community group has made some comments on this section.

Please see: w3c/odrl#4

@stonematt
Copy link
Contributor

@msporny @David-Chadwick this is a response from an external review, as such we should consider it a CR-Blocker. The details of their comments look like editorial comments and tweaks in a couple examples. Any objection to making these modifications in the spec? (and adding "CR-Blocker" to the issues)

@David-Chadwick
Copy link
Contributor

Can we say that this issue is subsumed by #269. Once we address #269, then we will know how to address this issue.

@burnburn
Copy link
Contributor

I will create a PR for this.

@burnburn
Copy link
Contributor

burnburn commented Jan 10, 2019

@burnburn ping myself to do the PR if still needed. @msporny is this still relevant?

@msporny
Copy link
Member

msporny commented Feb 2, 2019

In Example 11, the assigner should be a URI.
Something like https://dmv.example.gov/verifiers/all

All assigners are now URIs in the spec.

Perhaps they can also state that https://dmv.example.gov/verifiers/all is a PartyCollection.

We use JSON-LD's features to make "AllVerifiers" a PartyCollection.

They can also use "archive" as the action (from the ODRL common vocab)

We ended up using "Archival" in the example as lower-case class names are frowned upon for JSON-LD.

The type can be a "Set" (as this is the default Policy type).

I don't understand this suggestion.

They should update the narrative to read:

In the example above, the issuer (assigner) is prohibiting all verifiers (assignee) from storing the data in an archive.

Fixed in 8610f8f. Also cleaned up the other two examples that use ODRL.

@msporny
Copy link
Member

msporny commented Feb 2, 2019

I have responded to all comments from this review and applied a number of changes that were suggested. I think we're done from an editorial perspective here. @riannella please re-open if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HorizontalReview ready for PR This issue is ready for a Pull Request to be created to resolve it review-blocker
Projects
None yet
Development

No branches or pull requests

5 participants