Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crypto-suite names #23

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented Aug 2, 2023

This PR updates the cryptography suite names to conform to VC-Data Integrity specification.

This PR does not change the content of the examples or test vectors. Those will be updated after this PR is accepted and merged.


Preview | Diff

Names now conform to VC-DI specification.
Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for doing this!

Copy link

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This a subtle change, but I believe it reflects well working group consensus on this topic at the previous face to face, and it highlights an important extension point for data integrity proofs.

@msporny
Copy link
Member

msporny commented Aug 6, 2023

@OR13 wrote:

This a subtle change, but I believe it reflects well working group consensus on this topic at the previous face to face, and it highlights an important extension point for data integrity proofs.

Alright, good, then looks like we have consensus on this topic.

@Wind4Greg @dmitrizagidulin @iherman -- we need to register a new cryptosuite type in the security vocabulary for DataIntegrityProofs such that we can compress these longer strings into single byte values during semantic compression processes like what's used by CBOR-LD. I've opened w3c/vc-data-integrity#161 to track this concern, which doesn't need to hold up this PR.

@msporny
Copy link
Member

msporny commented Aug 10, 2023

Normative, multiple reviews, no changes requested, no objections, merging.

@msporny msporny merged commit 6f9b3fa into w3c:main Aug 10, 2023
1 check passed
@msporny
Copy link
Member

msporny commented Aug 10, 2023

Now that this is merged, @Wind4Greg, let's make a pass over all the cryptosuites and apply the naming uniformly over all of them, merge the sec:cryptosuiteString feature, regenerate all of the test vectors and finally be done with all of this. :)

@Wind4Greg
Copy link
Collaborator Author

Agree @msporny. Will review all for consistency. Have new test vectors ready to integrate into the documents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants