Update Cryptosuite Names. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But not in contents of examples or test vectors.
msporny
approved these changes
Aug 10, 2023
|
We failed to tag multiple reviewers for this PR, but this PR applies the same naming pattern approved over here: w3c/vc-di-ecdsa#23 |
|
Normative, multiple reviews (here and in PR w3c/vc-di-ecdsa#23), no changes requested, no objections, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
DataIntegrityProofcryptosuite attribute name in accordance to the recommendations in the VC Data Integrity Specification.It also removes the embedded issue concerning "cryptosuite naming" as this has be resolved via the Data Integrity Specification and these changes.
This PR does not update the contents of Example 3 or of the DataIntegrityProof based test vectors. As these need to be regenerated with the new names. PRs will be filed to update these after this PR is accepted.
Preview | Diff