Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language to align with v2 resolutions #38

Closed
OR13 opened this issue Nov 2, 2022 · 5 comments
Closed

Update language to align with v2 resolutions #38

OR13 opened this issue Nov 2, 2022 · 5 comments

Comments

@OR13
Copy link
Contributor

OR13 commented Nov 2, 2022

issuanceDate, validFrom, validUntil

@Sakurann
Copy link
Contributor

we should agree that iat/exp of VC-JWT are validity of the VC-JWT signature and are different from ValifFrom/ValidUntil that are validity of the data in the Credential #39 (comment)

@OR13
Copy link
Contributor Author

OR13 commented Jan 16, 2023

@Sakurann I agree they are different, I presented on this at TPAC.

Basically:

proof.created <=> iat
issuanceDate <=> nbf
expirationDate <=> exp

changing the name of the left hand side does not change the alignment of intention:

proof.created <=> iat
validFrom <=> nbf
validUntil <=> exp

@Sakurann
Copy link
Contributor

I agree with

proof.created <=> iat

I dont with

validFrom <=> nbf
validUntil <=> exp

ValidFrom and validUntil should not be mapped to any JWT Claim and used as-is. and exp JWT Claim should be used for the JWS signature validity.

Please see my proposal in issue #4

@OR13
Copy link
Contributor Author

OR13 commented Jan 17, 2023

@Sakurann

validFrom ~= issuanceDate
validUntil ~= expirationDate

See 1.1 production rules:

https://w3c.github.io/vc-jwt/#in-addition-to

These are the rules for 1.1...

We can of course change them or not implement a similar mapping for 2.0.

@OR13
Copy link
Contributor Author

OR13 commented Jun 30, 2023

No longer needs, especially when #88 is merged

@OR13 OR13 closed this as completed Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants