Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL spec test coverage report #3018

Closed
domenic opened this issue May 11, 2016 · 7 comments
Closed

URL spec test coverage report #3018

domenic opened this issue May 11, 2016 · 7 comments

Comments

@domenic
Copy link
Member

domenic commented May 11, 2016

FYI @annevk @Sebmaster @jasnell.

I managed to cobble this together:

Areas of lacking coverage are:

  • some origin serialization stuff (some purposefully untested)
  • The href setter
  • One early-return case in the hash setter
  • One "else" branch in IPv4 parsing
@annevk
Copy link
Member

annevk commented Feb 15, 2017

Oh sweet, can you generate new reports? Would love to add more tests, in particular now with Safari actively implementing.

@domenic
Copy link
Member Author

domenic commented Feb 15, 2017

Yeah, it's just npm run coverage from within the whatwg-url project. I've generated a new report at the same URL and updated the OP. Coverage went from 90 -> 95 and 85 -> 94 for those two files.

@jasnell
Copy link
Contributor

jasnell commented Feb 15, 2017

Very nice.

annevk added a commit that referenced this issue Feb 16, 2017
annevk added a commit to whatwg/url that referenced this issue Feb 16, 2017
Remove “dead code” found through
web-platform-tests/wpt#3018. (Note that the
API username/password setters are also no-ops for file URLs.)
annevk added a commit to whatwg/url that referenced this issue Feb 16, 2017
Remove “dead code” found through
web-platform-tests/wpt#3018. (Note that the
API username/password setters are also no-ops for file URLs.)
domenic pushed a commit that referenced this issue Feb 16, 2017
@domenic
Copy link
Member Author

domenic commented Feb 16, 2017

Updated the OP after #4882. Very nice.

@annevk
Copy link
Member

annevk commented Feb 17, 2017

Can we also get coverage on IDNA, which is just a single method in this library?

@GPHemsley
Copy link
Contributor

@domenic The links here are dead. Is this something that we're still looking to have? (I'm guessing yes.) Does this issue serve that purpose?

@domenic
Copy link
Member Author

domenic commented Jun 4, 2018

I think we got to 100% coverage at some point. I'm no longer actively tracking this, but you can checkout jsdom/whatwg-url, run npm install, then npm run coverage to get a report. I'll close this now since this issue isn't too helpful.

@domenic domenic closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants