Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stability checker does not recognize "multi-global" test modifications #5130

Closed
annevk opened this issue Mar 13, 2017 · 7 comments
Closed

Stability checker does not recognize "multi-global" test modifications #5130

annevk opened this issue Mar 13, 2017 · 7 comments
Assignees
Labels

Comments

@annevk
Copy link
Member

annevk commented Mar 13, 2017

#5129
https://travis-ci.org/w3c/web-platform-tests/jobs/210612033

Not entirely sure what the problem is here. @bobholt @jugglinmike

@annevk annevk added the infra label Mar 13, 2017
@jugglinmike
Copy link
Contributor

By the current configuration, TravisCI runs two identical builds for each
commit in a pull request. The error here is limited to just one of the two
"Chrome stability" jobs, and it describes a timeout after the instruction to
download information about the Chromedriver binary. In light of this, my
suspicion is that the error was caused by network instability. Do you mind if I
re-run the build to verify that it is not a recurring issue?

@annevk
Copy link
Member Author

annevk commented Mar 13, 2017

Sure go ahead.

@jugglinmike
Copy link
Contributor

The manually-triggered build has passed:

https://travis-ci.org/w3c/web-platform-tests/jobs/210612033

Do you think it is safe to close this issue? I realize this is not a particularly satisfying resolution, but I don't see any indication of an error in the project's code.

@annevk
Copy link
Member Author

annevk commented Mar 13, 2017

I think what we actually need to is to recognize the .any.js convention and run the corresponding .any.html and .any.worker.html tests. Same for the .worker.js convention. Would you mind of we reuse this issue for that?

@annevk
Copy link
Member Author

annevk commented Mar 13, 2017

See http://web-platform-tests.org/writing-tests/testharness.html for the documentation of this feature by the way.

@jugglinmike
Copy link
Contributor

Works for me! Although this calls for a change in title...

@jugglinmike jugglinmike changed the title Chrome build system fails when not given input? Stability checker does not recognize "multi-global" test modifications Mar 14, 2017
@jugglinmike jugglinmike self-assigned this Mar 14, 2017
@jugglinmike
Copy link
Contributor

Yesterday, @jgraham addressed this with the following patches: w3c/wpt-tools#195 and w3c/wptrunner#242. Because the "stability checker" Python script installs the latest version of the wptrunner utility by invoking git from the command line, no change to this repository is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants