Show details after each test finish in text-orientation.js #6949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
gsnedders,
hshiozawa,
kojiishi,
myakura,
plinss,
r12a and
snsk
|
@kojiishi as the author of this test, you probably want to review this change. |
Build PASSEDStarted: 2017-08-21 06:02:49 Unstable ResultsBrowser: "Safari 10.0" (failures allowed)View in: WPT PR Status | TravisCI
|
lashun66
approved these changes
Aug 22, 2017
kojiishi
approved these changes
Aug 22, 2017
Build PASSEDStarted: 2017-08-21 06:02:49 Failing Jobs
Unstable ResultsBrowser: "Safari 10.0" (failures allowed)View in: WPT PR Status | TravisCI
|
|
Thanks for reviewing. |
rachelandrew
pushed a commit
to rachelandrew/web-platform-tests
that referenced
this pull request
Nov 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the details be added to the page after each test is done. This can improve the performance of this test significantly when we don't get expected result for many characters.
This is because
getBoundingClientRectbasically need a synchronous flush on the document. If we add some element into the document every time before calling that, we are flushing the document for each character, which can be really slow. By collecting the failure info on a detached element, we can avoid such synchronous flush.