Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOMMatrix2DInit validate-fixup test need some improvement #7422

Closed
fserb opened this issue Sep 20, 2017 · 4 comments
Closed

DOMMatrix2DInit validate-fixup test need some improvement #7422

fserb opened this issue Sep 20, 2017 · 4 comments

Comments

@fserb
Copy link
Contributor

fserb commented Sep 20, 2017

Using canvas set/getTransform as a proxy for the test has some weird consequences. Namely, it seems consesus on Canvas side that we should not throw when getting an invalid input on those cases. Which means the first 8 tests on css/geometry-1/DOMMatrix2DInit-validate-fixup are wrong. Even thought they make sense looking at Geometry spec only.

A similar thing happens to the "infinity" or the "-0" input tests. Canvas has no guarantee to maintain those. So they can't be tested like this.

I could remove them, but it could be worth to discuss what to do long term. On principle, I'm ok with just testing what Canvas can see.

@fserb
Copy link
Contributor Author

fserb commented Sep 20, 2017

@zcorpan ?

@zcorpan
Copy link
Member

zcorpan commented Sep 20, 2017

See
whatwg/html#2975
#7355

@zcorpan
Copy link
Member

zcorpan commented Sep 20, 2017

-0 maybe ought to be clarified if it is roundtripped by getTransform, can you file an issue for html please? (edit: I filed whatwg/html#3060.)

@zcorpan
Copy link
Member

zcorpan commented Apr 17, 2018

Closing this since #7473 is merged. Please reopen or comment if there's still something to do here.

@zcorpan zcorpan closed this as completed Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants