You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using canvas set/getTransform as a proxy for the test has some weird consequences. Namely, it seems consesus on Canvas side that we should not throw when getting an invalid input on those cases. Which means the first 8 tests on css/geometry-1/DOMMatrix2DInit-validate-fixup are wrong. Even thought they make sense looking at Geometry spec only.
A similar thing happens to the "infinity" or the "-0" input tests. Canvas has no guarantee to maintain those. So they can't be tested like this.
I could remove them, but it could be worth to discuss what to do long term. On principle, I'm ok with just testing what Canvas can see.
The text was updated successfully, but these errors were encountered:
Using canvas set/getTransform as a proxy for the test has some weird consequences. Namely, it seems consesus on Canvas side that we should not throw when getting an invalid input on those cases. Which means the first 8 tests on
css/geometry-1/DOMMatrix2DInit-validate-fixup
are wrong. Even thought they make sense looking at Geometry spec only.A similar thing happens to the "infinity" or the "-0" input tests. Canvas has no guarantee to maintain those. So they can't be tested like this.
I could remove them, but it could be worth to discuss what to do long term. On principle, I'm ok with just testing what Canvas can see.
The text was updated successfully, but these errors were encountered: