Convert WebSocket tests to .any.js format #10598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Rebasing the old PR was too annoying. I omitted the |
|
Does the unicode string need to be literal unicode, or would |
|
It's a JavaScript string, so escapes would be equivalent, but if I don't have to touch that line it seems better for the diff and such. |
zcorpan
approved these changes
Apr 24, 2018
|
@zcorpan I think that would be better as a follow-up. I suspect if I did that everything would be seen as delete/add rather than a move-with-changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take 2 (see #5148 for take 1), fixes #2557.