Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for HTMLSelectElement.add() #1729

Closed

Conversation

kangxu
Copy link
Contributor

@kangxu kangxu commented Apr 7, 2015

No description provided.

@tobie tobie added the html label Apr 7, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4553

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 15, 2015

Please move the vars into the relevant test().

@xiuqijix
Copy link
Contributor

xiuqijix commented Dec 8, 2017

kangxu is inactive on wpt, I am going to clean up his open pr, this PR is fixed at #8625, close it.

@Honry Honry closed this Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants