revert b1a31096 - Test for non-support of <source media> #2565
Conversation
|
Reviewers for this pull request are: @Ms2ger, @gsnedders, @jdm, @jgraham, @plehegar, @sideshowbarker, @zcorpan, and @zqzhang. |
|
Critic review: https://critic.hoppipolla.co.uk/r/6172 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
|
||
| document.write( | ||
| "<source src='" + getVideoURI("/media/movie_300") + "'" + | ||
| " />" |
There was a problem hiding this comment.
Add media="not all" here to see that the attribute is actually ignored for video elements.
| <!DOCTYPE HTML> | ||
| <html> | ||
| <head> | ||
| <title>Change this to HTML5 Media Elements: 'media' attribute</title> |
There was a problem hiding this comment.
Remove "Change this to " :-D
LGTM after fixing that. Feel free to squash the commits into one if you like. Please add a new comment if you want me to merge.
There was a problem hiding this comment.
well thats embarrassing :]
updated, thanks a bunch
patrickkettner
force-pushed
the
readd-media-tests
branch
from
8fb6f0c
to
a0594d2
Compare
revert b1a3109 - Test for non-support of <source media>
|
Thank you! |
fixes #2189