New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix willValidate tests for <fieldset> and <output> #4553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://html.spec.whatwg.org/multipage/#dom-cva-willvalidate "The *willValidate* attribute's getter must return true, if this element is a **candidate for constraint validation**, and false otherwise" Per https://html.spec.whatwg.org/multipage/#candidate-for-constraint-validation "A *submittable element* is a **candidate for constraint validation** except when [...]" Per https://html.spec.whatwg.org/multipage/#category-submit "Submittable elements: button, input, object, select, textarea" Since <fieldset> and <output> are not *submittable elements*, they are never *candidates for constraint validation*, and therefore their willValidate properties must always return false.
Notifying @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. (Learn how reviewing works.) |
FirefoxTesting revision aa4f420 All results/html/semantics/forms/constraints/form-validation-willValidate.html
|
ChromeTesting revision aa4f420 All results/html/semantics/forms/constraints/form-validation-willValidate.html
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://html.spec.whatwg.org/multipage/#dom-cva-willvalidate
Per https://html.spec.whatwg.org/multipage/#candidate-for-constraint-validation
Per https://html.spec.whatwg.org/multipage/#category-submit
Since
<fieldset>
and<output>
are not submittable elements, they are never candidates for constraint validation, and therefore theirwillValidate
properties must always return false.