Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix willValidate tests for <fieldset> and <output> #4553

Merged
merged 1 commit into from Jan 18, 2017

Conversation

cvrebert
Copy link
Contributor

Per https://html.spec.whatwg.org/multipage/#dom-cva-willvalidate

The willValidate attribute's getter must return true, if this element is a candidate for constraint validation, and false otherwise

Per https://html.spec.whatwg.org/multipage/#candidate-for-constraint-validation

A submittable element is a candidate for constraint validation except when [...]

Per https://html.spec.whatwg.org/multipage/#category-submit

Submittable elements: button, input, object, select, textarea

Since <fieldset> and <output> are not submittable elements, they are never candidates for constraint validation, and therefore their willValidate properties must always return false.

Per https://html.spec.whatwg.org/multipage/#dom-cva-willvalidate
  "The *willValidate* attribute's getter must return true,
  if this element is a **candidate for constraint validation**,
  and false otherwise"
Per https://html.spec.whatwg.org/multipage/#candidate-for-constraint-validation
  "A *submittable element* is a **candidate for constraint validation**
  except when [...]"
Per https://html.spec.whatwg.org/multipage/#category-submit
  "Submittable elements: button, input, object, select, textarea"

Since <fieldset> and <output> are not *submittable elements*,
they are never *candidates for constraint validation*,
and therefore their willValidate properties must always return false.
@wpt-pr-bot
Copy link
Collaborator

@wpt-stability-bot
Copy link

Firefox

Testing revision aa4f420
Starting 10 test iterations
All results were stable

All results

/html/semantics/forms/constraints/form-validation-willValidate.html
Subtest Results
OK
[INPUT in TIME status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in DATE status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in TEXT status] The willValidate attribute must be true if an element is mutable PASS
[BUTTON in RESET status] Must be barred from the constraint validation PASS
[INPUT in BUTTON status] Must be barred from the constraint validation PASS
[INPUT in URL status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in DATETIME-LOCAL status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in COLOR status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in SEARCH status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in DATE status] Must be barred from the constraint validation if it is readonly PASS
[textarea] Must be barred from the constraint validation PASS
[INPUT in TIME status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in EMAIL status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in HIDDEN status] Must be barred from the constraint validation PASS
[INPUT in MONTH status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in EMAIL status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in TEL status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in FILE status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in MONTH status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in WEEK status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in EMAIL status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in WEEK status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in TIME status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in PASSWORD status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in COLOR status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in DATE status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in TEL status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in DATETIME-LOCAL status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in TEL status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in PASSWORD status] The willValidate attribute must be false if it has a datalist ancestor PASS
[textarea] The willValidate attribute must be false if it has a datalist ancestor FAIL
[textarea] The willValidate attribute must be true if an element is mutable PASS
[INPUT in PASSWORD status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in EMAIL status] Must be barred from the constraint validation if it is disabled PASS
[select] The willValidate attribute must be false if it has a datalist ancestor FAIL
[INPUT in TEXT status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in WEEK status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in TEXT status] Must be barred from the constraint validation if it is disabled PASS
[BUTTON in SUBMIT status] The willValidate attribute must be true if an element is mutable PASS
[BUTTON in SUBMIT status] The willValidate attribute must be false if it has a datalist ancestor FAIL
[INPUT in URL status] Must be barred from the constraint validation if it is readonly PASS
[output] The willValidate attribute must be false since OUTPUT is not a submittable element FAIL
[INPUT in MONTH status] The willValidate attribute must be false if it has a datalist ancestor PASS
[object] Must be barred from the constraint validation PASS
[INPUT in RESET status] Must be barred from the constraint validation PASS
[INPUT in FILE status] Must be barred from the constraint validation if it is readonly PASS
[BUTTON in BUTTON status] Must be barred from the constraint validation PASS
[INPUT in TIME status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in MONTH status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in SEARCH status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in SUBMIT status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in DATE status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in TEXT status] The willValidate attribute must be false if it has a datalist ancestor PASS
[fieldset] The willValidate attribute must be false since FIELDSET is not a submittable element PASS
[INPUT in COLOR status] Must be barred from the constraint validation if it is disabled PASS
[BUTTON in SUBMIT status] Must be barred from the constraint validation PASS
[INPUT in DATETIME-LOCAL status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in URL status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in COLOR status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in SEARCH status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in URL status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in FILE status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in SEARCH status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in FILE status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in SUBMIT status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in SUBMIT status] Must be barred from the constraint validation if it is disabled PASS
[select] The willValidate attribute must be true if an element is mutable PASS
[INPUT in DATETIME-LOCAL status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in TEL status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in WEEK status] Must be barred from the constraint validation if it is readonly PASS
[select] Must be barred from the constraint validation PASS
[INPUT in SUBMIT status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in PASSWORD status] Must be barred from the constraint validation if it is readonly PASS

@wpt-stability-bot
Copy link

Chrome

Testing revision aa4f420
Starting 10 test iterations
All results were stable

All results

/html/semantics/forms/constraints/form-validation-willValidate.html
Subtest Results
OK
[INPUT in TIME status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in DATE status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in TEXT status] The willValidate attribute must be true if an element is mutable PASS
[BUTTON in RESET status] Must be barred from the constraint validation PASS
[INPUT in BUTTON status] Must be barred from the constraint validation PASS
[INPUT in URL status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in DATETIME-LOCAL status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in COLOR status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in SEARCH status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in DATE status] Must be barred from the constraint validation if it is readonly PASS
[textarea] Must be barred from the constraint validation PASS
[INPUT in TIME status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in EMAIL status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in HIDDEN status] Must be barred from the constraint validation PASS
[INPUT in MONTH status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in EMAIL status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in TEL status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in FILE status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in MONTH status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in WEEK status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in EMAIL status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in WEEK status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in TIME status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in PASSWORD status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in COLOR status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in DATE status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in TEL status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in DATETIME-LOCAL status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in TEL status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in PASSWORD status] The willValidate attribute must be false if it has a datalist ancestor PASS
[textarea] The willValidate attribute must be false if it has a datalist ancestor PASS
[textarea] The willValidate attribute must be true if an element is mutable PASS
[INPUT in PASSWORD status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in EMAIL status] Must be barred from the constraint validation if it is disabled PASS
[select] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in TEXT status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in WEEK status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in TEXT status] Must be barred from the constraint validation if it is disabled PASS
[BUTTON in SUBMIT status] The willValidate attribute must be true if an element is mutable PASS
[BUTTON in SUBMIT status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in URL status] Must be barred from the constraint validation if it is readonly PASS
[output] The willValidate attribute must be false since OUTPUT is not a submittable element PASS
[INPUT in MONTH status] The willValidate attribute must be false if it has a datalist ancestor PASS
[object] Must be barred from the constraint validation PASS
[INPUT in RESET status] Must be barred from the constraint validation PASS
[INPUT in FILE status] Must be barred from the constraint validation if it is readonly PASS
[BUTTON in BUTTON status] Must be barred from the constraint validation PASS
[INPUT in TIME status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in MONTH status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in SEARCH status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in SUBMIT status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in DATE status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in TEXT status] The willValidate attribute must be false if it has a datalist ancestor PASS
[fieldset] The willValidate attribute must be false since FIELDSET is not a submittable element PASS
[INPUT in COLOR status] Must be barred from the constraint validation if it is disabled PASS
[BUTTON in SUBMIT status] Must be barred from the constraint validation PASS
[INPUT in DATETIME-LOCAL status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in URL status] Must be barred from the constraint validation if it is disabled PASS
[INPUT in COLOR status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in SEARCH status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in URL status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in FILE status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in SEARCH status] Must be barred from the constraint validation if it is readonly PASS
[INPUT in FILE status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in SUBMIT status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in SUBMIT status] Must be barred from the constraint validation if it is disabled PASS
[select] The willValidate attribute must be true if an element is mutable PASS
[INPUT in DATETIME-LOCAL status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in TEL status] The willValidate attribute must be true if an element is mutable PASS
[INPUT in WEEK status] Must be barred from the constraint validation if it is readonly PASS
[select] Must be barred from the constraint validation PASS
[INPUT in SUBMIT status] The willValidate attribute must be false if it has a datalist ancestor PASS
[INPUT in PASSWORD status] Must be barred from the constraint validation if it is readonly PASS

@zcorpan zcorpan merged commit eddc7c7 into master Jan 18, 2017
@zcorpan zcorpan deleted the fieldset-output-willValidate branch January 18, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants