<input type="week"> does not clamp its value #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test assumed that <input type="week"> cannot have its value set to a value that's outside the interval established by its min/max attributes, which is incorrect. <input type="range"> does perform that sort of clamping, using "When the element is suffering from an underflow/overflow" hooks: https://html.spec.whatwg.org/multipage/forms.html#range-state-(type=range):suffering-from-an-underflow But <input type="week">'s section doesn't setup any such hooks AFAICT, nor does its value sanitization algorithm implement any clamping: https://html.spec.whatwg.org/multipage/forms.html#week-state-(type=week):value-sanitization-algorithm
Firefox (nightly channel)Testing web-platform-tests at revision 4c46531 All results/html/semantics/forms/the-input-element/week.html
|
Chrome (unstable channel)Testing web-platform-tests at revision 4c46531 All results/html/semantics/forms/the-input-element/week.html
|
|
Since @wpt-pr-bot seems to have dropped this PR on the floor for some reason... Notifying @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @sideshowbarker, @zcorpan, and @zqzhang. |
cvrebert
added a commit
that referenced
this pull request
Jan 21, 2017
For the same reasons as #4591 (just s/week/date/g), <input type="date"> does not clamp its value based on its range limitations from its `min`/`max` attributes. This test incorrectly expected <input type="date"> to perform such clamping.
jdm
pushed a commit
that referenced
this pull request
Jan 21, 2017
For the same reasons as #4591 (just s/week/date/g), <input type="date"> does not clamp its value based on its range limitations from its `min`/`max` attributes. This test incorrectly expected <input type="date"> to perform such clamping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test assumed that
<input type="week">cannot have its value set to a value that's outside the interval established by its min/max attributes, which is incorrect.<input type="range">does perform that sort of clamping, using "When the element is suffering from an underflow/overflow" hooks:https://html.spec.whatwg.org/multipage/forms.html#range-state-(type=range):suffering-from-an-underflow
But
<input type="week">'s section doesn't setup any such hooks AFAICT, nor does its value sanitization algorithm implement any clamping:https://html.spec.whatwg.org/multipage/forms.html#week-state-(type=week):value-sanitization-algorithm
X-Ref: #4582