Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert of Create a change in external/wpt meant to be reverted (patchset #1 id:1 of https://codereview.chromium.org/2651533003/ ) #4629

Merged
merged 1 commit into from Jan 25, 2017

Conversation

jeffcarp
Copy link
Contributor

Reason for revert:
This commit was intended to be reverted to test how WPT Export handles reverted changes. See the bug for more context.

Original issue's description:

Create a change in external/wpt meant to be reverted

This is to test reverted changes in the WPT Export process.

BUG=679951

Review-Url: https://codereview.chromium.org/2651533003
Cr-Commit-Position: refs/heads/master@{#445651}
Committed: https://chromium.googlesource.com/chromium/src/+/b156b16a00574a89d85ccb034b30cdfd9cc5676a

TBR=qyearsley@chromium.org

Skipping CQ checks because original CL landed less than 1 days ago.

NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679951

Review-Url: https://codereview.chromium.org/2657613002
Cr-Commit-Position: refs/heads/master@{#445762}

…set #1 id:1 of https://codereview.chromium.org/2651533003/ )

Reason for revert:
This commit was intended to be reverted to test how WPT Export handles reverted changes. See the bug for more context.

Original issue's description:
> Create a change in external/wpt meant to be reverted
>
> This is to test reverted changes in the WPT Export process.
>
> BUG=679951
>
> Review-Url: https://codereview.chromium.org/2651533003
> Cr-Commit-Position: refs/heads/master@{#445651}
> Committed: https://chromium.googlesource.com/chromium/src/+/b156b16a00574a89d85ccb034b30cdfd9cc5676a

TBR=qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679951

Review-Url: https://codereview.chromium.org/2657613002
Cr-Commit-Position: refs/heads/master@{#445762}
@wpt-pr-bot
Copy link
Collaborator

@wpt-stability-bot
Copy link

Chrome (unstable channel)

Testing web-platform-tests at revision 8a2740a1b8b63300ed3a11137ad977f07ef1c72b
Using browser at version 55.0.2883.75
Starting 10 test iterations
All results were stable

All results

/html/semantics/forms/the-input-element/checkbox.html
Subtest Results
OK
pre-activation steps on checked checkbox PASS
canceled activation steps on unchecked checkbox PASS
click on mutable checkbox fires a click event, then an input event, then a change event FAIL
pre-activation steps on unchecked checkbox PASS
click on non-mutable checkbox doesn't fire the input or change event PASS
canceled activation steps on unchecked checkbox (indeterminate=true in onclick) PASS

@wpt-stability-bot
Copy link

Firefox (nightly channel)

Testing web-platform-tests at revision 8a2740a1b8b63300ed3a11137ad977f07ef1c72b
Using browser at version BuildID 20170123125947; SourceStamp 36486fdc3813ef7943ae5b07b4128866d1938a6c
Starting 10 test iterations
All results were stable

All results

/html/semantics/forms/the-input-element/checkbox.html
Subtest Results
OK
pre-activation steps on checked checkbox PASS
canceled activation steps on unchecked checkbox PASS
click on mutable checkbox fires a click event, then an input event, then a change event PASS
pre-activation steps on unchecked checkbox PASS
click on non-mutable checkbox doesn't fire the input or change event PASS
canceled activation steps on unchecked checkbox (indeterminate=true in onclick) PASS

@jeffcarp jeffcarp merged commit 15f055e into master Jan 25, 2017
@jeffcarp jeffcarp deleted the chromium-export-try branch January 25, 2017 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants