Disconnected <a> should not navigate #5759
Conversation
Require that they are all connected to a document that is fully active. There is enough difference between implementations that this appears to be web compatible. Tests: * web-platform-tests/wpt#5758 * web-platform-tests/wpt#5759 * web-platform-tests/wpt#5761 Fixes #2615.
|
As described in whatwg/html#2613 I'm flipping the pass condition. |
|
We should remove the second async_test now the pass condition is flipped I think. Will leave it there for now until I get some review. |
annevk
changed the title
Require that they are all connected to a document that is fully active. There is enough difference between implementations that this appears to be web compatible. Tests: * web-platform-tests/wpt#5758 * web-platform-tests/wpt#5759 * web-platform-tests/wpt#5761 Fixes #2615.
Require that they are all connected to a document that is fully active. There is enough difference between implementations that this appears to be web compatible. Tests: * web-platform-tests/wpt#5758 * web-platform-tests/wpt#5759 * web-platform-tests/wpt#5761 Fixes #2615.
|
Time to flip the pass condition back again, but only for |
annevk
force-pushed
the
annevk/disconnected-a-and-navigating
branch
from
2316482
to
d1ee685
Compare
Build PASSEDStarted: 2017-09-15 13:15:54 View more information about this build on: |
| link.target = "certifiedrandom" + type; | ||
| link.href = "/"; | ||
| document.body.appendChild(target); | ||
| target.onload = t.step_func(() => { |
There was a problem hiding this comment.
This test will pass after 500 ms if followed is true and the target never loads. That seems wrong?
There was a problem hiding this comment.
Good, seems that found a bug in Fx.
| @@ -0,0 +1,43 @@ | |||
| ["a", | |||
| "area"].forEach(type => { | |||
There was a problem hiding this comment.
Missing "link"
Also isn't this file partially redudant with active-document.window.js, introduced in #5758 ?
There was a problem hiding this comment.
The link element doesn't have target.
There was a problem hiding this comment.
I don't think it's redundant. That's a link in a document that's navigated away. Here it's a link that's simply not connected (or from a synthetic document).
Require that they are all connected to a document (except for <a>) that is fully active (including <a>). There is enough difference between implementations that this appears to be web compatible. Also perform a second connected check for <form>. Tests: * web-platform-tests/wpt#5758 * web-platform-tests/wpt#5759 * web-platform-tests/wpt#5761 Fixes #2615 and fixes #2708.
Require that they are all connected to a document (except for <a>) that is fully active (including <a>). There is enough difference between implementations that this appears to be web compatible. Also perform a second connected check for <form>. Tests: * web-platform-tests/wpt#5758 * web-platform-tests/wpt#5759 * web-platform-tests/wpt#5761 Fixes whatwg#2615 and fixes whatwg#2708.
Follow-up test for whatwg/html#2613.