Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: Update IDL for focus(options) #7915

Merged
merged 1 commit into from
Oct 26, 2017
Merged

HTML: Update IDL for focus(options) #7915

merged 1 commit into from
Oct 26, 2017

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Oct 20, 2017 •
edited by wpt-pr-bot
Loading

@ghost
Copy link

ghost commented Oct 20, 2017 •
edited by ghost
Loading

Build PASSED

Started: 2017-10-26 16:50:54
Finished: 2017-10-26 16:59:54

Failing Jobs

  • MicrosoftEdge:14.14393

View more information about this build on:

@zcorpan zcorpan mentioned this pull request Oct 20, 2017
Merged
@domenic domenic force-pushed the zcorpan/focus-options-preventscroll-idl branch from f9c7927 to de02311 Compare October 26, 2017 16:49
@domenic domenic merged commit a419e4e into master Oct 26, 2017
@domenic domenic deleted the zcorpan/focus-options-preventscroll-idl branch October 26, 2017 17:18
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Oct 28, 2017
Merged
chromium-wpt-export-bot pushed a commit that referenced this pull request Oct 28, 2017
@EiraGe @chromium-wpt-export-bot
Enable prevent scrolling in Element.focus()
675cdf9 
Implement Focusptions for focus() under a experimental flag.
FocusOptions has a boolean preventScroll (default false) to
prevent scrolling.

spec proposal: whatwg/html#2787 (comment)
tests:
#7915
#7917

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QeiK3lAXcmI

Bug:734166
Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
chromium-wpt-export-bot pushed a commit that referenced this pull request Oct 30, 2017
@EiraGe @chromium-wpt-export-bot
Enable prevent scrolling in Element.focus()
d520dc2 
Implement Focusptions for focus() under a experimental flag.
FocusOptions has a boolean preventScroll (default false) to
prevent scrolling.

spec proposal: whatwg/html#2787 (comment)
tests:
#7915
#7917

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QeiK3lAXcmI

Bug:734166
Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
chromium-wpt-export-bot pushed a commit that referenced this pull request Oct 30, 2017
@EiraGe @chromium-wpt-export-bot
Enable prevent scrolling in Element.focus()
c956639 
Implement Focusptions for focus() under a experimental flag.
FocusOptions has a boolean preventScroll (default false) to
prevent scrolling.

spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis
tests:
#7915
#7917

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QeiK3lAXcmI

Bug:734166
Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
chromium-wpt-export-bot pushed a commit that referenced this pull request Nov 2, 2017
@EiraGe @chromium-wpt-export-bot
Enable prevent scrolling in Element.focus()
1e0969a 
Implement Focusptions for focus() under a experimental flag.
FocusOptions has a boolean preventScroll (default false) to
prevent scrolling.

spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis
tests:
#7915
#7917

Intent to implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/QeiK3lAXcmI

Bug:734166
Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
chromium-wpt-export-bot pushed a commit that referenced this pull request Nov 8, 2017
@EiraGe @chromium-wpt-export-bot
Enable prevent scrolling in Element.focus()
1c8e6a7 
Implement Focusptions for focus() under a experimental flag.
FocusOptions has a boolean preventScroll (default false) to
prevent scrolling.

spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis
web-platform-tests:
#7915
#7917

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY

Bug:734166
Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
chromium-wpt-export-bot pushed a commit that referenced this pull request Nov 9, 2017
@EiraGe @chromium-wpt-export-bot
Enable prevent scrolling in Element.focus()
0017bb7 
Implement Focusptions for focus() under a experimental flag.
FocusOptions has a boolean preventScroll (default false) to
prevent scrolling.

spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis
web-platform-tests:
#7915
#7917

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY

Bug: 734166
Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
Reviewed-on: https://chromium-review.googlesource.com/731225
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515040}
chromium-wpt-export-bot pushed a commit that referenced this pull request Nov 9, 2017
@EiraGe @chromium-wpt-export-bot
Enable prevent scrolling in Element.focus()
7ff1abe 
Implement Focusptions for focus() under a experimental flag.
FocusOptions has a boolean preventScroll (default false) to
prevent scrolling.

spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis
web-platform-tests:
#7915
#7917

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY

Bug: 734166
Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
Reviewed-on: https://chromium-review.googlesource.com/731225
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515040}
MXEBot pushed a commit to mirror/chromium that referenced this pull request Nov 9, 2017
@EiraGe
Enable prevent scrolling in Element.focus()
d4b0ae2 
Implement Focusptions for focus() under a experimental flag.
FocusOptions has a boolean preventScroll (default false) to
prevent scrolling.

spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis
web-platform-tests:
web-platform-tests/wpt#7915
web-platform-tests/wpt#7917

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY

Bug: 734166
Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
Reviewed-on: https://chromium-review.googlesource.com/731225
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515040}
flowergom pushed a commit to webosose/chromium53 that referenced this pull request Sep 20, 2018
@EiraGe @lokesku
[upstream] Enable prevent scrolling in Element.focus()
1a8809e 
:Release Notes:
Enable prevent scrolling in Element.focus()

:Detailed Notes:
From upstream
https://chromium-review.googlesource.com/c/chromium/src/+/731225/5
https://www.chromestatus.com/feature/5745122025144320

    Enable prevent scrolling in Element.focus()

    Implement Focusptions for focus() under a experimental flag.
    FocusOptions has a boolean preventScroll (default false) to
    prevent scrolling.

    spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-management-apis
    web-platform-tests:
    web-platform-tests/wpt#7915
    web-platform-tests/wpt#7917

    Intent to implement and ship:
    https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/55sC81ciQgY

    Bug: 734166
    Change-Id: I47c1ebd9aebfc48064f9712d11c4d07ab8fabfa4
    Reviewed-on: https://chromium-review.googlesource.com/731225
    Reviewed-by: Rick Byers <rbyers@chromium.org>
    Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
    Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
    Commit-Queue: Ella Ge <eirage@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#515040}

With two main differences from upstream patch:
 - Removed "[RuntimeEnabled=FocusOptions]" from FocusOptions.idl.
 - Added '<(blink_core_output_dir)/html/FocusOptions.cpp' and
         '<(blink_core_output_dir)/html/FocusOptions.h'
   to core.gypi as otherwise I was getting a link error when
   building libcbe.

:Testing Performed:
Verified using sample hosted at:
http://<ip>:<port>/samplesForTesting/scrollerNative-5532/

:QA Notes:

:Issues Addressed:
[PLAT-64240] HTMLElement.focus preventScroll option to resolve
             stutter while scrolling

Change-Id: Ibcc0111e6b98b137bdfd693683a13a343c7ea372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

@foolip foolip foolip approved these changes

@jensl jensl Awaiting requested review from jensl

@tobie tobie Awaiting requested review from tobie

@yuki3 yuki3 Awaiting requested review from yuki3

Assignees
No one assigned
Labels
interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zcorpan @foolip @domenic @wpt-pr-bot