New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the cors-rfc1918 IDL file #9767
Update the cors-rfc1918 IDL file #9767
Conversation
434a93d
to
362269d
Compare
Build PASSEDStarted: 2018-03-07 23:06:21 View more information about this build on: |
@foolip - Added a test. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this should be inside the cors/
directory. fetch
is probably more suitable if we don't want this as its own top-level thing. @mikewest?
Putting them under |
Alrighty, moved as requested. |
Hello reviewer(s),
This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the
interfaces/
directory (instead of inline copies in the test files).