Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the cors-rfc1918 IDL file #9767

Merged

Conversation

lukebjerring
Copy link
Contributor

@lukebjerring lukebjerring commented Mar 2, 2018

Hello reviewer(s),

This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.

The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.

This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.

Please check that:
The Spec (and its source) is correct and up-to-date
All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the interfaces/ directory (instead of inline copies in the test files).

@lukebjerring lukebjerring force-pushed the idl-file-updates-cors-rfc1918 branch from 434a93d to 362269d Compare March 7, 2018 20:21
@w3c-bots
Copy link

w3c-bots commented Mar 7, 2018

Build PASSED

Started: 2018-03-07 23:06:21
Finished: 2018-03-07 23:16:10

View more information about this build on:

@domenic domenic removed their request for review April 20, 2018 21:13
@lukebjerring
Copy link
Contributor Author

@foolip - Added a test. PTAL.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this should be inside the cors/ directory. fetch is probably more suitable if we don't want this as its own top-level thing. @mikewest?

@mikewest
Copy link
Member

Putting them under /fetch/cors-rfc1918/ seems right to me. I'd also name them as .tentative, since I don't think we're anywhere near consensus that it's the right thing to do. :)

@lukebjerring lukebjerring added this to In progress in Improve idlharness.js Jun 18, 2018
@lukebjerring
Copy link
Contributor Author

Alrighty, moved as requested.

@annevk annevk merged commit 0007ac4 into web-platform-tests:master Jun 19, 2018
@lukebjerring lukebjerring moved this from In progress to Done in Improve idlharness.js Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants