SRI: clarify the CORS requirement in security considerations (fixes #418) #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| a cross-origin resource has certain content. | ||
|
|
||
| Attackers would attempt to load the resource with a known digest, and | ||
| watching for load failures. If the load fails, the attacker could surmise |
There was a problem hiding this comment.
nit: watching -> watch
|
lgtm % nits |
fmarier
force-pushed
the
sri-issue418
branch
from
adb107e
to
5805bfe
Compare
|
Good catch @metromoxie! I've addressed both of these in my last push. |
|
@jonathanKingston can you take a look, since you originally raised #418 |
|
👍, but let's see if @jonathanKingston agrees. |
|
Sorry for super delayed response here; I read the content but never got back to feeding back. This looks very strong to convey the message of why SRI can't openly do whatever we want. So yeah 👍 thanks @fmarier |
fmarier
pushed a commit
that referenced
this pull request
Sep 28, 2015
SRI: clarify the CORS requirement in security considerations (fixes #418)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.