-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misaligned steps in Section 7.2 #1913
Comments
Huh. Looks like Bikeshed is counting the switch cases as if they were in the parent numbered list - I confirmed this locally by adding a third switch case, and indeed the number of the next step increased to 9. This seems like a bug in Bikeshed? |
Oh, this is weird - this issue appears in Chrome but not in Firefox. @agl @jschanck is this a bug in either browser? The relevant HTML is this: <h3 class="heading settled" data-level="7.2" id="sctn-verifying-assertion"><span class="secno">7.2. </span><span class="content">Verifying an Authentication Assertion</span><a class="self-link" href="#sctn-verifying-assertion"></a></h3>
<p>In order to perform an <a data-link-type="dfn" href="#authentication-ceremony" id="ref-for-authentication-ceremony②⑤">authentication ceremony</a>, the <a data-link-type="dfn" href="#relying-party" id="ref-for-relying-party②⑥⑨" aria-expanded="false">Relying Party</a> MUST proceed as follows:</p>
<ol>
<li data-md="">
<p>Identify the user being authenticated and let <var>credentialRecord</var> be the <a data-link-type="dfn" href="#credential-record" id="ref-for-credential-record⑨">credential record</a> for the <a data-link-type="dfn" href="https://w3c.github.io/webappsec-credential-management/#concept-credential" id="ref-for-concept-credential①⑧">credential</a>:</p>
<dl class="switch">
<dt data-md="">If the user was identified before the <a data-link-type="dfn" href="#authentication-ceremony" id="ref-for-authentication-ceremony②⑥" aria-expanded="false">authentication ceremony</a> was initiated, e.g., via a username or cookie,
</dt><dd data-md="">
<p>verify that the identified <a data-link-type="dfn" href="#user-account" id="ref-for-user-account③③" aria-expanded="false">user account</a> contains a <a data-link-type="dfn" href="#credential-record" id="ref-for-credential-record①⓪">credential record</a> whose <a data-link-type="abstract-op" href="#abstract-opdef-credential-record-id" id="ref-for-abstract-opdef-credential-record-id②">id</a> equals <code><var>credential</var>.<code class="idl"><a data-link-type="idl" href="#dom-publickeycredential-rawid" id="ref-for-dom-publickeycredential-rawid③">rawId</a></code></code>.
Let <var>credentialRecord</var> be that <a data-link-type="dfn" href="#credential-record" id="ref-for-credential-record①①" aria-expanded="false">credential record</a>.
If <code><var>response</var>.<code class="idl"><a data-link-type="idl" href="#dom-authenticatorassertionresponse-userhandle" id="ref-for-dom-authenticatorassertionresponse-userhandle⑥">userHandle</a></code></code> is present,
verify that it equals the <a data-link-type="dfn" href="#user-handle" id="ref-for-user-handle②④" aria-expanded="false">user handle</a> of the <a data-link-type="dfn" href="#user-account" id="ref-for-user-account③④">user account</a>.</p>
</dd><dt data-md="">If the user was not identified before the <a data-link-type="dfn" href="#authentication-ceremony" id="ref-for-authentication-ceremony②⑦">authentication ceremony</a> was initiated,
</dt><dd data-md="">
<p>verify that <code><var>response</var>.<code class="idl"><a data-link-type="idl" href="#dom-authenticatorassertionresponse-userhandle" id="ref-for-dom-authenticatorassertionresponse-userhandle⑦">userHandle</a></code></code> is present.
Verify that the <a data-link-type="dfn" href="#user-account" id="ref-for-user-account③⑤" aria-expanded="false">user account</a> identified by <code><var>response</var>.<code class="idl"><a data-link-type="idl" href="#dom-authenticatorassertionresponse-userhandle" id="ref-for-dom-authenticatorassertionresponse-userhandle⑧">userHandle</a></code></code> contains a <a data-link-type="dfn" href="#credential-record" id="ref-for-credential-record①②">credential record</a> whose <a data-link-type="abstract-op" href="#abstract-opdef-credential-record-id" id="ref-for-abstract-opdef-credential-record-id③">id</a> equals <code><var>credential</var>.<code class="idl"><a data-link-type="idl" href="#dom-publickeycredential-rawid" id="ref-for-dom-publickeycredential-rawid④">rawId</a></code></code>.
Let <var>credentialRecord</var> be that <a data-link-type="dfn" href="#credential-record" id="ref-for-credential-record①③" aria-expanded="false">credential record</a>.</p>
</dd></dl>
</li>
<li data-md="">
<p>Let <var>cData</var>, <var>authData</var> and <var>sig</var> denote the value of <var>response</var>’s <code class="idl"><a data-link-type="idl" href="#dom-authenticatorresponse-clientdatajson" id="ref-for-dom-authenticatorresponse-clientdatajson①⓪">clientDataJSON</a></code>, <code class="idl"><a data-link-type="idl" href="#dom-authenticatorassertionresponse-authenticatordata" id="ref-for-dom-authenticatorassertionresponse-authenticatordata②" aria-expanded="false">authenticatorData</a></code>, and <code class="idl"><a data-link-type="idl" href="#dom-authenticatorassertionresponse-signature" id="ref-for-dom-authenticatorassertionresponse-signature②">signature</a></code> respectively.</p>
</li>
</ol> ChromeIn Chrome (120.0.6099.216 (Official Build) (64-bit)) this renders as: FirefoxIn Firefox (121.0.1 (64-bit)) this renders as: |
On a related note, though, both browsers do agree on the "outdentation" issue mentioned here. That code when "outdented" causes Bikeshed to emit different HTML, which seems to be rendered correctly in both browsers. |
@agl to file this as a crbug and ask Tab. |
This appears to have been fixed in Chrome as of |
Steps 7.2.7 and 7.2.8 disappeared from the latest version. The remained steps shifted by 2.
The text was updated successfully, but these errors were encountered: