Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions should specify partial dictionaries that modify AuthenticationExtensionsClient{Inputs, Outputs}JSON #1968

Open
jschanck opened this issue Sep 20, 2023 · 0 comments
Assignees
Labels
@Risk Items that are at risk for L3 type:editorial
Milestone

Comments

@jschanck
Copy link

Section 5.1.9 on the parseCreationOptionsFromJSON method states that

any DOMString attributes in PublicKeyCredentialCreationOptionsJSON that correspond to buffer source type attributes in PublicKeyCredentialCreationOptions. This conversion MUST also apply to any client extension inputs processed by the client.

While the expected behavior is reasonably clear, AuthenticationExtensionsClientInputsJSON is defined as the empty dictionary and no extensions currently modify it.

Proposed Change

Every partial dictionary that modifies AuthenticationExtensionsClientInputs or AuthenticationExtensionsClientOutputs should have a matching partial dictionary that modifies AuthenticationExtensionsClientInputsJSON or AuthenticationExtensionsClientOutputsJSON.

Also, as "the conversion" happens before extensions are "processed by the client", the second sentence quoted above should be something like:

This conversion MUST also apply to any client extension inputs supported by the client.

@nadalin nadalin added the @Risk Items that are at risk for L3 label Oct 25, 2023
@nadalin nadalin added this to the L3-WD-02 milestone Oct 25, 2023
@MasterKale MasterKale assigned MasterKale and unassigned jschanck Mar 20, 2024
@nadalin nadalin assigned nicksteele and jschanck and unassigned MasterKale Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@Risk Items that are at risk for L3 type:editorial
Projects
None yet
Development

No branches or pull requests

4 participants