Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

authenticatorMakeCredential() description of input PublicKeyCredential objects is incorrect #468

Closed
equalsJeffH opened this issue May 20, 2017 · 3 comments
Closed

authenticatorMakeCredential() description of input PublicKeyCredential objects is incorrect #468

equalsJeffH opened this issue May 20, 2017 · 3 comments
Assignees
@equalsJeffH @selfissued
Labels
subtype:algorithms/WebIDL type:technical
Milestone
WD-06

Comments

@equalsJeffH
Copy link
Contributor

equalsJeffH commented May 20, 2017 •
edited
Loading

the 6th bullet of authnrMakeCred() input params says:

An optional list of PublicKeyCredential objects provided by the Relying Party with the intention that, if any of these are known to the authenticator, it should not create a new credential.

At a minimum, s/PublicKeyCredential/PublicKeyCredentialDescriptor/.

However, note also issue #403 "some RPs may want to allow multiple registrations to the same account".
@equalsJeffH equalsJeffH added this to the WD-06 milestone May 20, 2017
@equalsJeffH equalsJeffH self-assigned this May 20, 2017
@equalsJeffH
Copy link
Contributor Author

should look into addressing this as a part of finishing PR #427

@equalsJeffH
Copy link
Contributor Author

This was essentially fixed in PR #464, and the reference to #403 is not terribly relevant here. close this?

@equalsJeffH
Copy link
Contributor Author

yes, this was fixed by PR #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@equalsJeffH equalsJeffH

@selfissued selfissued

Labels
subtype:algorithms/WebIDL type:technical
Projects
None yet
Milestone
WD-06
Development

No branches or pull requests
2 participants
@equalsJeffH @selfissued