-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing "scroll into view" Actions primitive #1005
Comments
Is this meant to target level 2? It seems more like an omission from the actions API than scope creep to me. |
Yeah, it's level 2. @jgraham and I discussed this on the IRC channel a few months ago. Adding it requires us to add new functionality, and that's something we're not meant to do in the CR period. |
IMO, we should follow what CSSOM View does here and offer all three of |
Something semantically equivalent would be good. There is definitely a
difference between scrolling an element into view, and scrolling a page by
a certain amount. Reading CSSOM, it looks like `scrollTo` and `scrollBy`
both end up delegating to `scroll`.
…On Wed, May 23, 2018 at 7:06 PM Geoffrey Sneddon ***@***.***> wrote:
IMO, we should follow what CSSOM View does here and offer all three of
scrollIntoView, scrollTo, and scrollBy on elements.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1005 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABuRbPlQIWBBT33O2saYrH91F34gGO3ks5t1aUbgaJpZM4O0r59>
.
|
|
I spoke to some users earlier today and they wanted the ability to scroll both by an amount and by web element, e.g. scroll(web element reference). AIUI Some observations:
This all sounds straight forward, but I have two open questions:
|
Here the resolution from TPAC (minutes):
|
fwiw: WebdriverIO has a custom implementation for this behavior that we have battle tested: https://github.com/webdriverio/webdriverio/blob/main/packages/webdriverio/src/commands/element/scrollIntoView.ts. It will fall back to the Web API if the remote environment doesn't support it. |
Mid-way through executing a sequence of actions it's useful to be able to scroll an element into view. A "scroll into view" primitive would enable this.
The text was updated successfully, but these errors were encountered: