Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTML attributes to use quotes #1186

Closed
wants to merge 1 commit into from
Closed

Update HTML attributes to use quotes #1186

wants to merge 1 commit into from

Conversation

InstyleVII
Copy link
Contributor

@InstyleVII InstyleVII commented Jan 8, 2018

Added quotes to all HTML attributes to improve editor tooling.


Preview | Diff

@InstyleVII
Copy link
Contributor Author

This is an updated version of my previous PR with just the addition of quotes to all HTML attributes as well as one minor fix to an incorrect class name.

@andreastt
Copy link
Member

I don’t see the value of this PR at all. This is not incorrect usage of attributes.

@InstyleVII
Copy link
Contributor Author

InstyleVII commented Jan 8, 2018

Two mains reasons:
Editor tooling - Some editors won't read links as links allowing you to nav to them from the editor if they aren't in quotes, VS Code is one such example
Consistency - We had some attributes using quotes and others not using quotes, now the document is consistently using quotes

@andreastt
Copy link
Member

The document is pretty much consistent in not using quotes where it is unnecessary already, so I wouldn’t go as far as calling that an inconsistency. I would also consider it a bug that your editor doesn’t recognise valid HTML attributes.

Now I’m not going to block a patch that adds quotes everywhere, but I would like to reiterate that they are completely pointless.

@InstyleVII
Copy link
Contributor Author

@shs96c mind assigning a reviewer?

@InstyleVII
Copy link
Contributor Author

Going to close as consensus is this isn't needed.

@InstyleVII InstyleVII closed this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants