Element Send Keys for "<input type=file>" has to also send a change event. #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimboo
requested review from
andreastt,
AutomatedTester,
jgraham and
shs96c
as code owners
andreastt
requested changes
May 30, 2018
index.html
Outdated
| @@ -6145,7 +6145,8 @@ <h3><dfn>Element Send Keys</dfn></h3> | |||
| If <var>multiple</var> is <code>true</code> | |||
| <var>files</var> are be appended to <var>element</var>’s <a>selected files</a>. | |||
|
|
|||
| <li><p><a>Fire</a> an <a><code>input</code></a> event. | |||
| <li><p><a>Fire</a> an <a><code>input</code></a> and | |||
| <a><code>change</code></a> event. | |||
There was a problem hiding this comment.
This might be OK, but I think it would be better to call out the ordering explicitly:
- Fire an input event on element.
- Fire a change event on element.
Or:
- Fire these events in order on element:
1.1. input
1.2. change
We should also change this to be specific about where to fire the element (note the use of element above).
There was a problem hiding this comment.
I've made those changes.
andreastt
approved these changes
May 30, 2018
|
I will take care of adding the test via https://bugzilla.mozilla.org/show_bug.cgi?id=1448792 |
|
@andreastt shouldn't we label that PR for |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 21, 2018
… event for <input type=file>. r=ato Adds a wdspec test to ensure the latest WebDriver specification changes for w3c/webdriver#1262. MozReview-Commit-ID: CQqq8VjBobU --HG-- extra : rebase_source : 6a0c2ed0e5a8dec746c85d67a71280de8011e9a6
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Jun 21, 2018
… event for <input type=file>. r=ato Adds a wdspec test to ensure the latest WebDriver specification changes for w3c/webdriver#1262. MozReview-Commit-ID: CQqq8VjBobU
moz-wptsync-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 13, 2018
…put type=file>. Adds a wdspec test to ensure the latest WebDriver specification changes for w3c/webdriver#1262. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1448792 gecko-commit: c26eb7edb08f6c7540a6f39d3dde16631a7a28a4 gecko-integration-branch: central gecko-reviewers: ato
jgraham
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 13, 2018
…put type=file>. Adds a wdspec test to ensure the latest WebDriver specification changes for w3c/webdriver#1262. bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1448792 gecko-commit: c26eb7edb08f6c7540a6f39d3dde16631a7a28a4 gecko-integration-branch: central gecko-reviewers: ato
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
… event for <input type=file>. r=ato Adds a wdspec test to ensure the latest WebDriver specification changes for w3c/webdriver#1262. MozReview-Commit-ID: CQqq8VjBobU UltraBlame original commit: c26eb7edb08f6c7540a6f39d3dde16631a7a28a4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
… event for <input type=file>. r=ato Adds a wdspec test to ensure the latest WebDriver specification changes for w3c/webdriver#1262. MozReview-Commit-ID: CQqq8VjBobU UltraBlame original commit: c26eb7edb08f6c7540a6f39d3dde16631a7a28a4
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
… event for <input type=file>. r=ato Adds a wdspec test to ensure the latest WebDriver specification changes for w3c/webdriver#1262. MozReview-Commit-ID: CQqq8VjBobU UltraBlame original commit: c26eb7edb08f6c7540a6f39d3dde16631a7a28a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As given by the HTML spec the
<input type=file>element sends both theinputandchangeevent. The spec currently only requires to fire theinputevent.https://html.spec.whatwg.org/#file-upload-state-(type=file):event-input-3
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file
Testcase: https://output.jsbin.com/vijukozuro/1