Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for calculating the accessible label and the accessible role of elements #1444

Merged
merged 4 commits into from
May 29, 2020

Conversation

AutomatedTester
Copy link
Contributor

@AutomatedTester AutomatedTester commented Sep 25, 2019

…ole of elements

Fixes #1439


Preview | Diff

@AutomatedTester
Copy link
Contributor Author

This is to start getting feedback from accessibility teams. If they are happy I will add wpt

@whimboo whimboo changed the title Add support for calculating the accessible label and the accessible r… Add support for calculating the accessible label and the accessible role of elements Sep 25, 2019
Copy link
Member

@andreastt andreastt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know ARIA so I’m relying on @cookiecrook’s judgement that these are the right things to expose.

I have a couple of questions and a few concerns:

  • Are these ARIA concepts that is implementable in all browsers?
  • Is there vendor commitment to implement these WebDriver endpoints?
  • Should this go in th WebDriver core spec, or should they be WebDriver extensions within ARIA?
  • There are no tests.

There is precedence for non-core web standards to extend WebDriver to expose automation endpoints. This is what the Permissions API does and would likely serve as a good example to follow here.

Beyond this, there are a few very minor editorial issues to address.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@cookiecrook
Copy link

I don’t know ARIA so I’m relying on @cookiecrook’s judgement that these are the right things to expose.

I have a couple of questions and a few concerns:

  • Are these ARIA concepts that is implementable in all browsers?

Neither of these is specific to ARIA so it would not make sense to tie them to that spec.

If you wanted to group them, you could possibly call them "accessibility"-specific but the lines between accessibility and mainstream are pretty blurry already. Accessibility as a grouping may make sense because other accessibility concepts (some ARIA-related) may be needed later.

  • Is there vendor commitment to implement these WebDriver endpoints?

Yes for these two. Right now it's the lowest common denominator that every vendor agrees would be useful here. Each major vendor (Blink, WebKit, Gecko) has these exposed in Developer Tools contexts already, so I expect implementation will be trivial.

  • Should this go in th WebDriver core spec, or should they be WebDriver extensions within ARIA?

Not ARIA specific, so it'd be inappropriate to host it there.

Also, this came up at the TPAC F2F, and I confirmed they are not otherwise available in the JavaScript context. If I understood @AutomatedTester correctly (or was it another WebDriver WG member?), that means these would have be in the core WebDriver spec.

Every major vendor has these concepts central in each implementation, but there is no way to get at this from an over-the-counter JavaScript context currently... Exposing them in WebDriver would allow us to test implementations against each other.

@andreastt
Copy link
Member

Very good, thanks! That dispels most of my concerns.

What is missing then are the editorial fixups and tests for this to move forward.

AutomatedTester added a commit to AutomatedTester/web-platform-tests that referenced this pull request May 27, 2020
This adds tests for the new Get Computed Role and
Get Computed Label endpoints
described in w3c/webdriver#1444
index.html Outdated Show resolved Hide resolved
@jgraham jgraham dismissed andreastt’s stale review May 29, 2020 18:35

Concerns are addressed per comment

@jgraham jgraham merged commit 162e738 into master May 29, 2020
@jgraham
Copy link
Member

jgraham commented May 29, 2020

Tests are web-platform-tests/wpt#23793

AutomatedTester added a commit to AutomatedTester/web-platform-tests that referenced this pull request Jan 11, 2021
This adds tests for the new Get Computed Role and
Get Computed Label endpoints
described in w3c/webdriver#1444
AutomatedTester added a commit to web-platform-tests/wpt that referenced this pull request Jan 11, 2021
* Add WebDriver tests for computed label/role

This adds tests for the new Get Computed Role and
Get Computed Label endpoints
described in w3c/webdriver#1444

* Correct lint issue and add more tests

* address comments
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 15, 2021
…ole, a=testonly

Automatic update from web-platform-tests
Add WebDriver tests for computed label/role (#23793)

* Add WebDriver tests for computed label/role

This adds tests for the new Get Computed Role and
Get Computed Label endpoints
described in w3c/webdriver#1444

* Correct lint issue and add more tests

* address comments
--

wpt-commits: fc208a8949b99577b7fd42d83f7dc8c1df65daad
wpt-pr: 23793
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jan 16, 2021
…ole, a=testonly

Automatic update from web-platform-tests
Add WebDriver tests for computed label/role (#23793)

* Add WebDriver tests for computed label/role

This adds tests for the new Get Computed Role and
Get Computed Label endpoints
described in w3c/webdriver#1444

* Correct lint issue and add more tests

* address comments
--

wpt-commits: fc208a8949b99577b7fd42d83f7dc8c1df65daad
wpt-pr: 23793

UltraBlame original commit: 9db8fd2a79bc65ecec2e60cd7b3a40fa3d812d27
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jan 19, 2021
…ole, a=testonly

Automatic update from web-platform-tests
Add WebDriver tests for computed label/role (#23793)

* Add WebDriver tests for computed label/role

This adds tests for the new Get Computed Role and
Get Computed Label endpoints
described in w3c/webdriver#1444

* Correct lint issue and add more tests

* address comments
--

wpt-commits: fc208a8949b99577b7fd42d83f7dc8c1df65daad
wpt-pr: 23793
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Jan 25, 2021
…ole, a=testonly

Automatic update from web-platform-tests
Add WebDriver tests for computed label/role (#23793)

* Add WebDriver tests for computed label/role

This adds tests for the new Get Computed Role and
Get Computed Label endpoints
described in w3c/webdriver#1444

* Correct lint issue and add more tests

* address comments
--

wpt-commits: fc208a8949b99577b7fd42d83f7dc8c1df65daad
wpt-pr: 23793

UltraBlame original commit: aff84f01ba96c28b173e7ff30ccf44ac9c6863c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility primitives: computedRole and computedLabel
4 participants