Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add definition for "weak map" #1713

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add definition for "weak map" #1713

merged 1 commit into from
Mar 7, 2024

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Jan 11, 2023 •
edited by pr-preview bot
Loading

@whimboo
Copy link
Contributor Author

whimboo commented Jan 11, 2023

The tests are currently failing because the [=infra/map=] cannot be resolved. Using [=map=] instead fails as well because it's defined in infra and html. Same most likely applies to the [=WeakMap=] reference which should be resolved to the ecmascript spec.

@jgraham, @foolip does one of you have an idea how to get this fixed or whom to ask for help? Thanks!

@whimboo whimboo changed the title Add definition of "weak map" Add definition for "weak map" Jan 11, 2023
@whimboo whimboo merged commit d05e463 into master Mar 7, 2024
@whimboo whimboo deleted the weakmap branch March 7, 2024 11:34
@whimboo whimboo restored the weakmap branch March 7, 2024 11:36
whimboo added a commit to whimboo/webdriver that referenced this pull request Mar 7, 2024
@whimboo
Revert "Add definition of "weak map" (w3c#1713)"
c67ef7c 
This reverts commit d05e463.
@whimboo whimboo mentioned this pull request Mar 7, 2024
Merged
@whimboo
Copy link
Contributor Author

whimboo commented Mar 7, 2024

Oh even through the CI results for this PR didnt' show any failure all the CI tasks actually fail with this PR merged.

I'm going to backout via #1803

whimboo added a commit that referenced this pull request Mar 7, 2024
@whimboo
Revert "Add definition of "weak map" (#1713)" (#1803)
b7d581e 
This reverts commit d05e463.
github-actions bot added a commit that referenced this pull request Mar 7, 2024
@whimboo @github-actions
Revert "Add definition of "weak map" (#1713)" (#1803)
26fa72a 
SHA: b7d581e
Reason: push, by whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@whimboo whimboo deleted the weakmap branch March 7, 2024 11:45
@whimboo whimboo mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whimboo @jgraham