Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for modules in limited event pages #289

Closed
carlosjeurissen opened this issue Oct 13, 2022 · 4 comments
Closed

Add support for modules in limited event pages #289

carlosjeurissen opened this issue Oct 13, 2022 · 4 comments
Labels
implemented: firefox Implemented in Firefox implemented: safari Implemented in Safari

Comments

@carlosjeurissen
Copy link
Contributor

carlosjeurissen commented Oct 13, 2022 •
edited
Loading

Currently Google Chrome supports "type": "module" for background serviceWorkers. During our 2022-10-13 meeting, while discussing #282, Safari and Firefox agreed it makes sense to also add support "type": "module" for limited event pages.

Basically given this syntax in manifest.json:

"background": {
  "scripts": ["script1.js", "script2.js"],
  "type": "module"
}

The browser would generate a _generated_background_page.html which looks like this:

<head></head><body>
<script type="module" src="script1.js"></script>
<script type="module" src="script2.js"></script>
</body>

Dedicated issue on the Mozilla bugtracker:
https://bugzilla.mozilla.org/show_bug.cgi?id=1811443
@carlosjeurissen carlosjeurissen added supportive: safari Supportive from Safari supportive: firefox Supportive from Firefox labels Oct 13, 2022
@carlosjeurissen carlosjeurissen mentioned this issue Oct 13, 2022
Open
@Rob--W Rob--W mentioned this issue Oct 13, 2022
Merged
@xeenon
Copy link
Collaborator

xeenon commented Oct 13, 2022

I filed this for Safari/WebKit: https://bugs.webkit.org/show_bug.cgi?id=246475

@Rob--W
Copy link
Member

Rob--W commented Jan 20, 2023

I filed a new Firefox bug specifically for event pages: https://bugzilla.mozilla.org/show_bug.cgi?id=1811443, since the originally linked Bugzilla issue was about type="module" of Service workers.

@xeenon xeenon added implemented: safari Implemented in Safari and removed supportive: safari Supportive from Safari labels Feb 16, 2023
@xeenon
Copy link
Collaborator

xeenon commented Feb 16, 2023

Safari Technology Preview supports this now, and the Safari 16.4 beta.

@Rob--W Rob--W mentioned this issue Mar 5, 2023
Merged
1 task
@carlosjeurissen
Copy link
Contributor Author

Since this is or will be supported in both Firefox and Safari. And considering Chrome will not support the limited event pages. No further action seems to be needed here.
@Rob--W Seems this has since been implemented Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=1811443), can you update the Firefox stand to implemented and subsequently close the issue?

@Rob--W Rob--W added implemented: firefox Implemented in Firefox opposed: chrome Opposed by Chrome and removed supportive: firefox Supportive from Firefox opposed: chrome Opposed by Chrome labels Oct 20, 2023
@Rob--W Rob--W closed this as completed Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
implemented: firefox Implemented in Firefox implemented: safari Implemented in Safari
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xeenon @carlosjeurissen @Rob--W